Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-30166#correcting typos #72886

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

brendan-daly-red-hat
Copy link

@brendan-daly-red-hat brendan-daly-red-hat commented Mar 8, 2024

Versions:
4.13+

Issue:
https://issues.redhat.com/browse/OCPBUGS-30166

Link to docs preview:
https://72886--ocpdocs-pr.netlify.app/openshift-enterprise/latest/nodes/pods/nodes-pods-vertical-autoscaler

QE review not required as fixing non-technical typo.

Additional information:

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 8, 2024
@openshift-ci-robot
Copy link

@brendan-daly-red-hat: This pull request references Jira Issue OCPBUGS-30166, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 8, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 8, 2024

🤖 Wed Mar 13 12:02:13 - Prow CI generated the docs preview:
https://72886--ocpdocs-pr.netlify.app

@brendan-daly-red-hat brendan-daly-red-hat changed the title OCPBUGS-30166:correcting typos OCPBUGS-30166#correcting typos Mar 12, 2024
@openshift-ci-robot openshift-ci-robot removed jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 12, 2024
@openshift-ci-robot
Copy link

@brendan-daly-red-hat: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

Versions:
4.13.z, 4.14.z, 4.15.z

Issue:
https://issues.redhat.com/browse/OCPBUGS-30166

Link to docs preview:
https://72886--ocpdocs-pr.netlify.app/openshift-enterprise/latest/nodes/pods/nodes-pods-vertical-autoscaler

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@brendan-daly-red-hat
Copy link
Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 12, 2024
@bergerhoffer
Copy link
Contributor

/label peer-review-in-progress

Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, thanks for fixing these typos!

No QE is required for just basic typos. And this does have to go into 4.16 as well (since it's going into main). That should be fine since it's just typo changes.

Also, before this can be merged, you'll need to squash so that you only have 1 commit.

Great job!

@brendan-daly-red-hat
Copy link
Author

@bergerhoffer, Hi Andrea, I've removed the request for a QE review, updated the 'Versions:' heading to show that it applies to all versions from 4.13, and squashed so that there is only one commit. Thanks.

@bergerhoffer
Copy link
Contributor

/label peer-review-done
/remove-label peer-review-needed
/remove-label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Mar 12, 2024
Copy link

openshift-ci bot commented Mar 13, 2024

@brendan-daly-red-hat: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@brendan-daly-red-hat
Copy link
Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Mar 13, 2024
@adellape adellape self-assigned this Mar 13, 2024
@adellape adellape added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Mar 13, 2024
@adellape adellape added this to the Continuous Release milestone Mar 13, 2024
@adellape adellape merged commit 7bae3cd into openshift:main Mar 13, 2024
2 checks passed
@adellape
Copy link
Contributor

/cherrypick enterprise-4.16

@adellape
Copy link
Contributor

/cherrypick enterprise-4.15

@adellape
Copy link
Contributor

/cherrypick enterprise-4.14

@adellape
Copy link
Contributor

/cherrypick enterprise-4.13

@openshift-cherrypick-robot

@adellape: new pull request created: #73079

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@adellape: #72886 failed to apply on top of branch "enterprise-4.14":

Applying: OCPBUGS-30166:correcting typos
Using index info to reconstruct a base tree...
M	modules/nodes-pods-vertical-autoscaler-about.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/nodes-pods-vertical-autoscaler-about.adoc
CONFLICT (content): Merge conflict in modules/nodes-pods-vertical-autoscaler-about.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCPBUGS-30166:correcting typos
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@adellape: new pull request created: #73080

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@adellape: #72886 failed to apply on top of branch "enterprise-4.13":

Applying: OCPBUGS-30166:correcting typos
Using index info to reconstruct a base tree...
M	modules/nodes-pods-vertical-autoscaler-about.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/nodes-pods-vertical-autoscaler-about.adoc
CONFLICT (content): Merge conflict in modules/nodes-pods-vertical-autoscaler-about.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCPBUGS-30166:correcting typos
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adellape adellape removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants