-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-30166#correcting typos #72886
Conversation
@brendan-daly-red-hat: This pull request references Jira Issue OCPBUGS-30166, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
🤖 Wed Mar 13 12:02:13 - Prow CI generated the docs preview: |
@brendan-daly-red-hat: No Jira issue is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/label peer-review-needed |
/label peer-review-in-progress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, thanks for fixing these typos!
No QE is required for just basic typos. And this does have to go into 4.16 as well (since it's going into main). That should be fine since it's just typo changes.
Also, before this can be merged, you'll need to squash so that you only have 1 commit.
Great job!
9ccb891
to
476508c
Compare
@bergerhoffer, Hi Andrea, I've removed the request for a QE review, updated the 'Versions:' heading to show that it applies to all versions from 4.13, and squashed so that there is only one commit. Thanks. |
/label peer-review-done |
476508c
to
265af33
Compare
@brendan-daly-red-hat: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/label merge-review-needed |
/cherrypick enterprise-4.16 |
/cherrypick enterprise-4.15 |
/cherrypick enterprise-4.14 |
/cherrypick enterprise-4.13 |
@adellape: new pull request created: #73079 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@adellape: #72886 failed to apply on top of branch "enterprise-4.14":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@adellape: new pull request created: #73080 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@adellape: #72886 failed to apply on top of branch "enterprise-4.13":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Versions:
4.13+
Issue:
https://issues.redhat.com/browse/OCPBUGS-30166
Link to docs preview:
https://72886--ocpdocs-pr.netlify.app/openshift-enterprise/latest/nodes/pods/nodes-pods-vertical-autoscaler
QE review not required as fixing non-technical typo.
Additional information: