Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHDEVDOCS-5957: Content creation for GitOps 1.10.3 RN #73166

Merged
merged 1 commit into from Mar 18, 2024
Merged

RHDEVDOCS-5957: Content creation for GitOps 1.10.3 RN #73166

merged 1 commit into from Mar 18, 2024

Conversation

Dhruv-Soni11
Copy link
Contributor

@Dhruv-Soni11 Dhruv-Soni11 commented Mar 14, 2024 •
edited

Version(s):

This PR must be CP'ed to GitOps 1.12, GitOps 1.11, and GitOps 1.10 releases.

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5957

Link to docs preview:

https://73166--docspreview.netlify.app/openshift-gitops/latest/release_notes/gitops-release-notes#release-notes-for-gitops-title-1-10-3_gitops-release-notes

SME review: @reginapizza
QE review: @varshab1210
Peer review: @Srivaralakshmi

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 14, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 14, 2024 •
edited

🤖 Updated build preview is available at:
https://73166--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/37937

@Dhruv-Soni11 Dhruv-Soni11 changed the title Content creation for 1.10.3 RN RHDEVDOCS-5957: Content creation for GitOps 1.10.3 RN Mar 14, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 14, 2024 •
edited by openshift-ci bot

@Dhruv-Soni11: This pull request references RHDEVDOCS-5957 which is a valid jira issue.

In response to this:

Version(s):

This PR must be CP'ed to GitOps 1.12, GitOps 1.11, and GitOps 1.10 releases.

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5957

Link to docs preview:

https://73166--docspreview.netlify.app/openshift-gitops/latest/release_notes/gitops-release-notes#release-notes-for-gitops-title-1-10-3_gitops-release-notes

SME review: @reginapizza
QE review: @varshab1210
Peer review: @Srivaralakshmi

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 14, 2024
@varshab1210
Copy link

LGTM

reginapizza
reginapizza approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@reginapizza reginapizza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Srivaralakshmi
Srivaralakshmi reviewed Mar 15, 2024
View reviewed changes
Copy link
Member

@Srivaralakshmi Srivaralakshmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dhruv-Soni11 Good work! Please add the errata updates section as discussed and put [WIP] in the PR description. Please keep the XX and NN parts in the links. Otherwise, the link will throw errors and PR builds won't pass.

The rest of the content LGTM. Thank you!

@Dhruv-Soni11 Dhruv-Soni11 changed the title RHDEVDOCS-5957: Content creation for GitOps 1.10.3 RN WIP: RHDEVDOCS-5957: Content creation for GitOps 1.10.3 RN Mar 15, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 15, 2024
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 15, 2024
@Dhruv-Soni11
Copy link
Contributor Author

@Dhruv-Soni11 Good work! Please add the errata updates section as discussed and put [WIP] in the PR description. Please keep the XX and NN parts in the links. Otherwise, the link will throw errors and PR builds won't pass.

The rest of the content LGTM. Thank you!

Hi @Srivaralakshmi - I have added the content for the Errata updates. Please check.

Srivaralakshmi
Srivaralakshmi reviewed Mar 18, 2024
View reviewed changes
Copy link
Member

@Srivaralakshmi Srivaralakshmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dhruv-Soni11 PTAL at my comment and let me know once the PR is ready. TY!

modules/gitops-release-notes-for-1-10-3.adoc Outdated Show resolved Hide resolved
@Dhruv-Soni11 Dhruv-Soni11 force-pushed the RHDEVDOCS-5957-new branch 2 times, most recently from 2769797 to 0030e38 Compare March 18, 2024 08:55
Srivaralakshmi
Srivaralakshmi reviewed Mar 18, 2024
View reviewed changes
Copy link
Member

@Srivaralakshmi Srivaralakshmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dhruv-Soni11 PTAL at my comments and revise the PR.

modules/gitops-release-notes-for-1-10-3.adoc Outdated Show resolved Hide resolved
modules/gitops-release-notes-for-1-10-3.adoc Outdated Show resolved Hide resolved
modules/gitops-release-notes-for-1-10-3.adoc Outdated Show resolved Hide resolved
@Srivaralakshmi Srivaralakshmi added peer-review-done Signifies that the peer review team has reviewed this PR lgtm Indicates that a PR is ready to be merged. merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR and removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Mar 18, 2024
@Srivaralakshmi Srivaralakshmi changed the title WIP: RHDEVDOCS-5957: Content creation for GitOps 1.10.3 RN RHDEVDOCS-5957: Content creation for GitOps 1.10.3 RN Mar 18, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 18, 2024
@Srivaralakshmi Srivaralakshmi added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. merge-review-needed Signifies that the merge review team needs to review this PR labels Mar 18, 2024
@Srivaralakshmi Srivaralakshmi added merge-review-in-progress Signifies that the merge review team is reviewing this PR gitops and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Mar 18, 2024
Srivaralakshmi
Srivaralakshmi reviewed Mar 18, 2024
View reviewed changes
Copy link
Member

@Srivaralakshmi Srivaralakshmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dhruv-Soni11 Left a review comment. Please address it. TY!

modules/gitops-release-notes-for-1-10-3.adoc Outdated Show resolved Hide resolved
@Srivaralakshmi Srivaralakshmi removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Mar 18, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 18, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2024
@Srivaralakshmi Srivaralakshmi added merge-review-needed Signifies that the merge review team needs to review this PR merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Mar 18, 2024
@Srivaralakshmi Srivaralakshmi merged commit 89d225f into openshift:gitops-docs Mar 18, 2024
1 check passed
@Srivaralakshmi
Copy link
Member

/cherrypick gitops-docs-1.10

@Srivaralakshmi
Copy link
Member

/cherrypick gitops-docs-1.11

@Srivaralakshmi
Copy link
Member

/cherrypick gitops-docs-1.12

@openshift-cherrypick-robot
Copy link

@Srivaralakshmi: #73166 failed to apply on top of branch "gitops-docs-1.10":

Applying: Content creation for 1.10.3 RN
Using index info to reconstruct a base tree...
M	release_notes/gitops-release-notes.adoc
Falling back to patching base and 3-way merge...
Auto-merging release_notes/gitops-release-notes.adoc
CONFLICT (content): Merge conflict in release_notes/gitops-release-notes.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Content creation for 1.10.3 RN
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick gitops-docs-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 18, 2024
Merged
@openshift-cherrypick-robot
Copy link

@Srivaralakshmi: new pull request created: #73277

In response to this:

/cherrypick gitops-docs-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@Srivaralakshmi: new pull request created: #73278

In response to this:

/cherrypick gitops-docs-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 18, 2024
Merged
@Dhruv-Soni11 Dhruv-Soni11 mentioned this pull request Mar 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Srivaralakshmi Srivaralakshmi Srivaralakshmi left review comments

@reginapizza reginapizza reginapizza approved these changes

Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. gitops jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Dhruv-Soni11 @ocpdocs-previewbot @openshift-ci-robot @varshab1210 @Srivaralakshmi @openshift-cherrypick-robot @reginapizza