Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS OBSDOCS-904 - Logging 5.8.5 Release Notes #73271

Merged

Conversation

shreyasiddhartha
Copy link
Contributor

@shreyasiddhartha shreyasiddhartha commented Mar 18, 2024

Change type: Doc update; Logging Z-Stream Release Notes - 5.8.5
Doc JIRA: https://issues.redhat.com/browse/OBSDOCS-904

Fix Version: 4.12, 4.13, 4.14, 4.15

Note: Since this branch isn't from main, I have created PRs for each versions. This PR is for 4.15.
4.14: #73848
4.13: #73849
4.12: #73850

Doc Preview: https://73271--ocpdocs-pr.netlify.app/openshift-enterprise/latest/logging/logging_release_notes/logging-5-8-release-notes#logging-release-notes-5-8-5_logging-5-8-release-notes

SME Review: @periklis
QE Review: @anpingli
Peer Review: @agantony

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 18, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 18, 2024

🤖 Thu Mar 28 09:08:06 - Prow CI generated the docs preview:
https://73271--ocpdocs-pr.netlify.app

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 26, 2024
Copy link

@periklis periklis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anpingli
Copy link

LGTM

@shreyasiddhartha
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 27, 2024
@agantony
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Mar 27, 2024
Copy link
Contributor

@agantony agantony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few suggestions for your consideration; overall lgtm!

modules/logging-release-notes-5-8-5.adoc Outdated Show resolved Hide resolved
modules/logging-release-notes-5-8-5.adoc Outdated Show resolved Hide resolved
modules/logging-release-notes-5-8-5.adoc Outdated Show resolved Hide resolved
modules/logging-release-notes-5-8-5.adoc Outdated Show resolved Hide resolved
modules/logging-release-notes-5-8-5.adoc Outdated Show resolved Hide resolved
modules/logging-release-notes-5-8-5.adoc Show resolved Hide resolved
modules/logging-release-notes-5-8-5.adoc Show resolved Hide resolved
modules/logging-release-notes-5-8-5.adoc Outdated Show resolved Hide resolved
@agantony
Copy link
Contributor

/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 27, 2024
Copy link

openshift-ci bot commented Mar 28, 2024

@shreyasiddhartha: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shreyasiddhartha
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Mar 28, 2024
@JoeAldinger JoeAldinger added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Mar 28, 2024
@JoeAldinger JoeAldinger merged commit 4235fbc into openshift:enterprise-4.15 Mar 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants