-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-30827: Adding SDN deprecation statements across the doc set #73316
Conversation
@ahardin-rh: This pull request references Jira Issue OCPBUGS-30827, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
🤖 Fri Apr 05 13:24:25 - Prow CI generated the docs preview: |
@ahardin-rh, I wonder about the feature matrix: https://docs.openshift.com/container-platform/4.15/networking/openshift_sdn/about-openshift-sdn.html#nw-ovn-kubernetes-matrix_about-openshift-sdn This module repeats in the OVN-Kubernetes about as well. This probably just needs to list the features for OVN-Kubernetes and can be therefore simplified. For 4.17 it would definitely come out. Not sure for 4.16. |
cd24a21
to
3791240
Compare
@ahardin-rh: This pull request references Jira Issue OCPBUGS-30827, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
e5365fc
to
867d357
Compare
@ahardin-rh: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/remove-label peer-review-needed /label peer-review-in-progress |
@@ -0,0 +1,27 @@ | |||
// Text snippet included in the following assemblies: | |||
// | |||
// * networking/about-networking.adoc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://73316--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/about-networking seems to render fine on my end
@@ -8,6 +8,8 @@ toc::[] | |||
|
|||
As a cluster administrator, you can migrate to the OpenShift SDN network plugin from the OVN-Kubernetes network plugin. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file does not render in the preview. Not sure why.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dfitzmau Thank you! I will re-check these two files.
@@ -8,6 +8,8 @@ toc::[] | |||
|
|||
As a cluster administrator, you can rollback to the OVN-Kubernetes network plugin from the OpenShift SDN network plugin if the migration to OpenShift SDN is unsuccessful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file does not render in the preview.
Hi @ahardin-rh . Overall LTGM, but I cannot access two files on the preivew. Am I missing something? |
No QE needed since the language itself is already approved. Looks like some files were removed in 4.15, which is why they don't render in preview. I think we can merge as it is. |
@ahardin-rh: Jira Issue OCPBUGS-30827 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/cherrypick enterprise-4.15 |
/cherrypick enterprise-4.16 |
@ahardin-rh: cannot checkout In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ahardin-rh: new pull request created: #74437 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ahardin-rh: new pull request created: #74438 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…ppet OCPBUGS-30827: Adding SDN deprecation statements across the doc set
Version(s):
4.15+
Issue:
https://issues.redhat.com/browse/OCPBUGS-30827
Link to docs preview:
https://73316--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/about-networking
This deprecation language is already reviewed and approved by PM, as it was included in the release notes. This PR adds the language to the body of the text in the form of a snippet.