Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-30827: Adding SDN deprecation statements across the doc set #73316

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

ahardin-rh
Copy link
Contributor

@ahardin-rh ahardin-rh commented Mar 18, 2024

Version(s):
4.15+

Issue:
https://issues.redhat.com/browse/OCPBUGS-30827

Link to docs preview:
https://73316--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/about-networking

This deprecation language is already reviewed and approved by PM, as it was included in the release notes. This PR adds the language to the body of the text in the form of a snippet.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 18, 2024
@openshift-ci-robot
Copy link

@ahardin-rh: This pull request references Jira Issue OCPBUGS-30827, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Version(s):
4.15+

Issue:
https://issues.redhat.com/browse/OCPBUGS-30827

Link to docs preview:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Mar 18, 2024
@ahardin-rh ahardin-rh changed the title OCPBUGS-30827: Adding SDN deprecation statements across the doc set [WIP]OCPBUGS-30827: Adding SDN deprecation statements across the doc set Mar 18, 2024
@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 18, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 18, 2024

🤖 Fri Apr 05 13:24:25 - Prow CI generated the docs preview:
https://73316--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@jab-rh
Copy link
Contributor

jab-rh commented Mar 27, 2024

@ahardin-rh, I wonder about the feature matrix: https://docs.openshift.com/container-platform/4.15/networking/openshift_sdn/about-openshift-sdn.html#nw-ovn-kubernetes-matrix_about-openshift-sdn

This module repeats in the OVN-Kubernetes about as well. This probably just needs to list the features for OVN-Kubernetes and can be therefore simplified. For 4.17 it would definitely come out. Not sure for 4.16.

@ahardin-rh ahardin-rh force-pushed the sdn-derecation-snippet branch 2 times, most recently from cd24a21 to 3791240 Compare April 4, 2024 19:57
@ahardin-rh ahardin-rh changed the title [WIP]OCPBUGS-30827: Adding SDN deprecation statements across the doc set OCPBUGS-30827: Adding SDN deprecation statements across the doc set Apr 5, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 5, 2024
@ahardin-rh ahardin-rh added this to the Continuous Release milestone Apr 5, 2024
@ahardin-rh ahardin-rh added branch/enterprise-4.15 branch/enterprise-4.16 peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 5, 2024
@openshift-ci-robot
Copy link

@ahardin-rh: This pull request references Jira Issue OCPBUGS-30827, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Version(s):
4.15+

Issue:
https://issues.redhat.com/browse/OCPBUGS-30827

Link to docs preview:
https://73316--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/about-networking

This deprecation language is already reviewed and approved by PM, as it was included in the release notes. This PR adds the language to the body of the text in the form of a snippet.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ahardin-rh ahardin-rh removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Apr 5, 2024
Copy link

openshift-ci bot commented Apr 5, 2024

@ahardin-rh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ahardin-rh ahardin-rh self-assigned this Apr 5, 2024
@dfitzmau
Copy link
Contributor

dfitzmau commented Apr 5, 2024

/remove-label peer-review-needed

/label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 5, 2024
@@ -0,0 +1,27 @@
// Text snippet included in the following assemblies:
//
// * networking/about-networking.adoc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was unable to open the following assemblies:
Screenshot from 2024-04-05 16-15-56
Screenshot from 2024-04-05 16-17-23

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -8,6 +8,8 @@ toc::[]

As a cluster administrator, you can migrate to the OpenShift SDN network plugin from the OVN-Kubernetes network plugin.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file does not render in the preview. Not sure why.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dfitzmau Thank you! I will re-check these two files.

@@ -8,6 +8,8 @@ toc::[]

As a cluster administrator, you can rollback to the OVN-Kubernetes network plugin from the OpenShift SDN network plugin if the migration to OpenShift SDN is unsuccessful.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file does not render in the preview.

@dfitzmau
Copy link
Contributor

dfitzmau commented Apr 5, 2024

Hi @ahardin-rh . Overall LTGM, but I cannot access two files on the preivew. Am I missing something?

@ahardin-rh ahardin-rh added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Apr 9, 2024
@ahardin-rh ahardin-rh removed the request for review from anuragthehatter April 9, 2024 21:02
@ahardin-rh
Copy link
Contributor Author

No QE needed since the language itself is already approved. Looks like some files were removed in 4.15, which is why they don't render in preview. I think we can merge as it is.

@ahardin-rh ahardin-rh merged commit df17c7b into openshift:main Apr 9, 2024
2 checks passed
@openshift-ci-robot
Copy link

@ahardin-rh: Jira Issue OCPBUGS-30827 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

In response to this:

Version(s):
4.15+

Issue:
https://issues.redhat.com/browse/OCPBUGS-30827

Link to docs preview:
https://73316--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/about-networking

This deprecation language is already reviewed and approved by PM, as it was included in the release notes. This PR adds the language to the body of the text in the form of a snippet.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ahardin-rh
Copy link
Contributor Author

/cherrypick enterprise-4.15

@ahardin-rh
Copy link
Contributor Author

/cherrypick enterprise-4.16

@openshift-cherrypick-robot

@ahardin-rh: cannot checkout enterprise-51.5: error checking out "enterprise-51.5": exit status 1 error: pathspec 'enterprise-51.5' did not match any file(s) known to git

In response to this:

/cherrypick enterprise-51.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@ahardin-rh: new pull request created: #74437

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@ahardin-rh: new pull request created: #74438

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

xenolinux pushed a commit to xenolinux/openshift-docs that referenced this pull request Apr 10, 2024
…ppet

OCPBUGS-30827: Adding SDN deprecation statements across the doc set
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.15 branch/enterprise-4.16 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants