Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OBSDOCS-821: Docs for log filtering by metadata #73318

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

shreyasiddhartha
Copy link
Contributor

@shreyasiddhartha shreyasiddhartha commented Mar 18, 2024

Change type: Doc update; Filter log messages based on metadata
Doc JIRA: https://issues.redhat.com/browse/OBSDOCS-821

NOTE: Docs need to be commented out for merging until logging 5.9 release day.
JIRA tracking commenting out: OBSDOCS-834

Fix Version: 4.13+ (logging 5.9+)

Doc Preview: Filtering logs metadata

SME Review: @cahartma
QE Review: @QiaolingTang
Peer Review: @agantony

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 18, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 18, 2024

@shreyasiddhartha: This pull request references OBSDOCS-821 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Change type: Doc update; Filter log messages based on metadata
Doc JIRA: https://issues.redhat.com/browse/OBSDOCS-821

NOTE: Docs need to be commented out for merging until logging 5.9 release day.

Fix Version: 4.13+ (logging 5.9+)

Doc Preview:

SME Review:
QE Review:
Peer Review:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 18, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 18, 2024

🤖 Tue Mar 26 12:13:00 - Prow CI generated the docs preview:
https://73318--ocpdocs-pr.netlify.app

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 18, 2024

@shreyasiddhartha: This pull request references OBSDOCS-821 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Change type: Doc update; Filter log messages based on metadata
Doc JIRA: https://issues.redhat.com/browse/OBSDOCS-821

NOTE: Docs need to be commented out for merging until logging 5.9 release day.

Fix Version: 4.13+ (logging 5.9+)

Doc Preview:

SME Review:
QE Review:
Peer Review:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 18, 2024

@shreyasiddhartha: This pull request references OBSDOCS-821 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Change type: Doc update; Filter log messages based on metadata
Doc JIRA: https://issues.redhat.com/browse/OBSDOCS-821

NOTE: Docs need to be commented out for merging until logging 5.9 release day.

Fix Version: 4.13+ (logging 5.9+)

Doc Preview:

SME Review: @cahartma
QE Review:
Peer Review:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 20, 2024

@shreyasiddhartha: This pull request references OBSDOCS-821 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Change type: Doc update; Filter log messages based on metadata
Doc JIRA: https://issues.redhat.com/browse/OBSDOCS-821

NOTE: Docs need to be commented out for merging until logging 5.9 release day.

Fix Version: 4.13+ (logging 5.9+)

Doc Preview: Filtering logs metadata

SME Review: @cahartma
QE Review:
Peer Review:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@briandooley
Copy link
Contributor

/rebuild

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 21, 2024

@shreyasiddhartha: This pull request references OBSDOCS-821 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Change type: Doc update; Filter log messages based on metadata
Doc JIRA: https://issues.redhat.com/browse/OBSDOCS-821

NOTE: Docs need to be commented out for merging until logging 5.9 release day.

Fix Version: 4.13+ (logging 5.9+)

Doc Preview: Filtering logs metadata

SME Review: @cahartma
QE Review:
Peer Review:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 22, 2024

@shreyasiddhartha: This pull request references OBSDOCS-821 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Change type: Doc update; Filter log messages based on metadata
Doc JIRA: https://issues.redhat.com/browse/OBSDOCS-821

NOTE: Docs need to be commented out for merging until logging 5.9 release day.

Fix Version: 4.13+ (logging 5.9+)

Doc Preview: Filtering logs metadata

SME Review: @cahartma
QE Review: @QiaolingTang
Peer Review:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@QiaolingTang
Copy link

LGTM.

@shreyasiddhartha
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 26, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 26, 2024

@shreyasiddhartha: This pull request references OBSDOCS-821 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Change type: Doc update; Filter log messages based on metadata
Doc JIRA: https://issues.redhat.com/browse/OBSDOCS-821

NOTE: Docs need to be commented out for merging until logging 5.9 release day.
JIRA tracking commenting out: OBSDOCS-834

Fix Version: 4.13+ (logging 5.9+)

Doc Preview: Filtering logs metadata

SME Review: @cahartma
QE Review: @QiaolingTang
Peer Review: @agantony

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Mar 26, 2024

@shreyasiddhartha: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

openshift-ci bot commented Mar 26, 2024

@shreyasiddhartha: Those labels are not set on the issue: merge-review-needed

In response to this:

/remove-label merge-review-needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shreyasiddhartha
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Mar 26, 2024
@kelbrown20 kelbrown20 added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Mar 26, 2024
Copy link
Contributor

@kelbrown20 kelbrown20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@kelbrown20 kelbrown20 merged commit 00b251e into openshift:main Mar 26, 2024
2 checks passed
@kelbrown20
Copy link
Contributor

/cherrypick enterprise-4.16

@kelbrown20
Copy link
Contributor

/cherrypick enterprise-4.15

@kelbrown20
Copy link
Contributor

/cherrypick enterprise-4.14

@kelbrown20
Copy link
Contributor

/cherrypick enterprise-4.13

@openshift-cherrypick-robot

@kelbrown20: new pull request created: #73740

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@kelbrown20: new pull request created: #73741

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@kelbrown20: new pull request created: #73742

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@kelbrown20: new pull request created: #73743

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kelbrown20 kelbrown20 added this to the Continuous Release milestone Mar 26, 2024
@kelbrown20 kelbrown20 removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants