Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OBSDOCS-875: Update CLI command for granting permission to configure … #73398

Merged
merged 1 commit into from
Mar 22, 2024
Merged

OBSDOCS-875: Update CLI command for granting permission to configure … #73398

merged 1 commit into from
Mar 22, 2024

Conversation

eromanova97
Copy link
Contributor

@eromanova97 eromanova97 commented Mar 19, 2024 •
edited

Version(s): enterprise-4.12 and later

Issue: OBSDOC-S875

Link to docs preview: Granting users permission to configure monitoring for user-defined projects

QE review:

  • QE has approved this change.

Additional information: I also added a verification step to enhance our docs.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 19, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 19, 2024 •
edited by openshift-ci bot

@eromanova97: This pull request references OBSDOCS-875 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s): enterprise-4.12 and later

Issue: OBSDOC-S875

Link to docs preview:

QE review:

  • QE has approved this change.

Peer review:

  • Peer review done

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 19, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 19, 2024 •
edited

🤖 Fri Mar 22 08:29:57 - Prow CI generated the docs preview:
https://73398--ocpdocs-pr.netlify.app

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 19, 2024 •
edited by openshift-ci bot

@eromanova97: This pull request references OBSDOCS-875 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s): enterprise-4.12 and later

Issue: OBSDOC-S875

Link to docs preview: Granting users permission to configure monitoring for user-defined projects

QE review:

  • QE has approved this change.

Peer review:

  • Peer review done

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 20, 2024 •
edited by openshift-ci bot

@eromanova97: This pull request references OBSDOCS-875 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s): enterprise-4.12 and later

Issue: OBSDOC-S875

Link to docs preview: Granting users permission to configure monitoring for user-defined projects

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 20, 2024 •
edited by openshift-ci bot

@eromanova97: This pull request references OBSDOCS-875 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s): enterprise-4.12 and later

Issue: OBSDOC-S875

Link to docs preview: Granting users permission to configure monitoring for user-defined projects

QE review:

  • QE has approved this change.

Additional information: I also added a verification step to enhance our docs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 21, 2024
@machine424
Copy link
Contributor

Thanks!
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 21, 2024 •
edited by openshift-ci bot

@eromanova97: This pull request references OBSDOCS-875 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s): enterprise-4.12 and later

Issue: OBSDOC-S875

Link to docs preview: Granting users permission to configure monitoring for user-defined projects

QE review:

  • QE has approved this change.

Additional information: I also added a verification step to enhance our docs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eromanova97
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 21, 2024
@kcarmichael08 kcarmichael08 added peer-review-in-progress Signifies that the peer review team is reviewing this PR branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 21, 2024
kcarmichael08
kcarmichael08 reviewed Mar 21, 2024
View reviewed changes
Copy link
Contributor

@kcarmichael08 kcarmichael08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion; lgtm!

.../monitoring-granting-users-permission-to-configure-monitoring-for-user-defined-projects.adoc Outdated Show resolved Hide resolved
@kcarmichael08 kcarmichael08 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Mar 21, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 22, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 22, 2024

@eromanova97: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@eromanova97
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Mar 22, 2024
@ShaunaDiaz ShaunaDiaz added this to the Continuous Release milestone Mar 22, 2024
@ShaunaDiaz
Copy link
Contributor

/remove-label merge-review-needed

@openshift-ci openshift-ci bot removed the merge-review-needed Signifies that the merge review team needs to review this PR label Mar 22, 2024
@ShaunaDiaz ShaunaDiaz merged commit d450343 into openshift:main Mar 22, 2024
2 checks passed
@ShaunaDiaz
Copy link
Contributor

/cherrypick enterprise-4.12

@ShaunaDiaz
Copy link
Contributor

/cherrypick enterprise-4.13

@ShaunaDiaz
Copy link
Contributor

/cherrypick enterprise-4.14

@ShaunaDiaz
Copy link
Contributor

/cherrypick enterprise-4.15

@ShaunaDiaz
Copy link
Contributor

/cherrypick enterprise-4.16

@openshift-cherrypick-robot
Copy link

@ShaunaDiaz: new pull request created: #73605

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 22, 2024
Merged
@openshift-cherrypick-robot
Copy link

@ShaunaDiaz: new pull request created: #73606

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 22, 2024
Merged
@openshift-cherrypick-robot
Copy link

@ShaunaDiaz: new pull request created: #73607

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 22, 2024
Merged
@openshift-cherrypick-robot
Copy link

@ShaunaDiaz: new pull request created: #73608

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 22, 2024
Merged
@openshift-cherrypick-robot
Copy link

@ShaunaDiaz: new pull request created: #73609

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 22, 2024
Merged
@eromanova97 eromanova97 deleted the OBSDOCS-875 branch March 25, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juzhao juzhao juzhao left review comments

@machine424 machine424 machine424 left review comments

@bburt-rh bburt-rh bburt-rh left review comments

@kcarmichael08 kcarmichael08 kcarmichael08 left review comments

Assignees

@juzhao juzhao

@machine424 machine424

Labels
branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@eromanova97 @openshift-ci-robot @ocpdocs-previewbot @machine424 @ShaunaDiaz @openshift-cherrypick-robot @juzhao @bburt-rh @kcarmichael08