-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-31247: Remove "(for user-provisioned installations)" reference #73512
Conversation
@palonsoro: This pull request references Jira Issue OCPBUGS-31247, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
🤖 Thu Mar 21 10:29:23 - Prow CI generated the docs preview: |
…e for accepting CSRs on etcd restore procedure This PR removes the above mentioned parenthesis and also improves the technical description of the CSRs mentioned at that step.
8bb9ed9
to
5d87b1f
Compare
New changes are detected. LGTM label has been removed. |
@palonsoro: This pull request references Jira Issue OCPBUGS-31247, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest |
@palonsoro: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/label peer-review-needed |
Note: The only change I made since @geliu2016 reviewed is adding a missing space, so I understand that QE should not need to review again. If it is needed, please let us know. Thanks. |
LGTM! I assume this should also go in 4.16 (upcoming) - if so, please edit the PR body to reflect that and the merge reviewer can add the label for that. Thanks! |
You are right @kcarmichael08 . I fixed PR body. Thanks! |
/label merge-review-needed |
/remove-label merge-review-needed |
@palonsoro: Jira Issue OCPBUGS-31247: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-31247 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/cherrypick enterprise-4.14 |
/cherrypick enterprise-4.15 |
/cherrypick enterprise-4.16 |
@ShaunaDiaz: #73512 failed to apply on top of branch "enterprise-4.14":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ShaunaDiaz: #73512 failed to apply on top of branch "enterprise-4.15":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ShaunaDiaz: #73512 failed to apply on top of branch "enterprise-4.16":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hey @palonsoro, it looks like all three branch cherry picks failed for #73512. You can create manual CPs that resolve the conflicts and then let me or the merge review team know and we can merge those up for you. |
/cherrypick enterprise-4.16 |
@ShaunaDiaz: new pull request created: #73610 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
#73486 had unmerged cherry picks |
/cherrypick enterprise-4.15 |
/cherrypick enterprise-4.14 |
Thanks @ShaunaDiaz |
@ShaunaDiaz: new pull request created: #73611 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ShaunaDiaz: new pull request created: #73612 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR removes the above mentioned parenthesis from the etcd restore procedure, because it goes against documentation guidelines of avoiding parenthesis. It also improves the technical description of the CSRs mentioned at that step.
Version(s):
4.16,4.15, 4.14
Issue:
https://issues.redhat.com/browse/OCPBUGS-31247
Link to docs preview:
https://73512--ocpdocs-pr.netlify.app/openshift-enterprise/latest/backup_and_restore/control_plane_backup_and_restore/disaster_recovery/scenario-2-restoring-cluster-state
QE review:
Additional information:
(none)