Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-31247: Remove "(for user-provisioned installations)" reference #73512

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

palonsoro
Copy link
Contributor

@palonsoro palonsoro commented Mar 21, 2024

This PR removes the above mentioned parenthesis from the etcd restore procedure, because it goes against documentation guidelines of avoiding parenthesis. It also improves the technical description of the CSRs mentioned at that step.

Version(s):
4.16,4.15, 4.14

Issue:
https://issues.redhat.com/browse/OCPBUGS-31247

Link to docs preview:

https://73512--ocpdocs-pr.netlify.app/openshift-enterprise/latest/backup_and_restore/control_plane_backup_and_restore/disaster_recovery/scenario-2-restoring-cluster-state

QE review:

  • QE has approved this change.

Additional information:

(none)

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Mar 21, 2024
@openshift-ci-robot
Copy link

@palonsoro: This pull request references Jira Issue OCPBUGS-31247, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @geliu2016

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR removes the above mentioned parenthesis from the etcd restore procedure, because it goes against documentation guidelines of avoiding parenthesis. It also improves the technical description of the CSRs mentioned at that step.

Version(s):
4.15, 4.14

Issue:
https://issues.redhat.com/browse/OCPBUGS-31247

Link to docs preview:
(not ready yet)

QE review:

  • QE has approved this change.

Additional information:

(none)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from geliu2016 March 21, 2024 08:13
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 21, 2024
Copy link

@geliu2016 geliu2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 21, 2024

🤖 Thu Mar 21 10:29:23 - Prow CI generated the docs preview:
https://73512--ocpdocs-pr.netlify.app

…e for accepting CSRs on etcd restore procedure

This PR removes the above mentioned parenthesis and also improves
the technical description of the CSRs mentioned at that step.
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2024
Copy link

openshift-ci bot commented Mar 21, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci-robot
Copy link

@palonsoro: This pull request references Jira Issue OCPBUGS-31247, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @geliu2016

In response to this:

This PR removes the above mentioned parenthesis from the etcd restore procedure, because it goes against documentation guidelines of avoiding parenthesis. It also improves the technical description of the CSRs mentioned at that step.

Version(s):
4.15, 4.14

Issue:
https://issues.redhat.com/browse/OCPBUGS-31247

Link to docs preview:
(not ready yet)

QE review:

  • QE has approved this change.

Additional information:

(none)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from geliu2016 March 21, 2024 09:06
@palonsoro
Copy link
Contributor Author

/retest

Copy link

openshift-ci bot commented Mar 21, 2024

@palonsoro: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@palonsoro
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 21, 2024
@palonsoro
Copy link
Contributor Author

palonsoro commented Mar 21, 2024

Note: The only change I made since @geliu2016 reviewed is adding a missing space, so I understand that QE should not need to review again. If it is needed, please let us know.

Thanks.

@kcarmichael08 kcarmichael08 added peer-review-in-progress Signifies that the peer review team is reviewing this PR branch/enterprise-4.14 branch/enterprise-4.15 and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 21, 2024
@kcarmichael08
Copy link
Contributor

LGTM! I assume this should also go in 4.16 (upcoming) - if so, please edit the PR body to reflect that and the merge reviewer can add the label for that. Thanks!

@kcarmichael08 kcarmichael08 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Mar 21, 2024
@palonsoro
Copy link
Contributor Author

You are right @kcarmichael08 . I fixed PR body.

Thanks!

@palonsoro
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Mar 22, 2024
@ShaunaDiaz
Copy link
Contributor

/remove-label merge-review-needed

@openshift-ci openshift-ci bot removed the merge-review-needed Signifies that the merge review team needs to review this PR label Mar 22, 2024
@ShaunaDiaz ShaunaDiaz merged commit 537276e into openshift:main Mar 22, 2024
2 checks passed
@openshift-ci-robot
Copy link

@palonsoro: Jira Issue OCPBUGS-31247: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-31247 has been moved to the MODIFIED state.

In response to this:

This PR removes the above mentioned parenthesis from the etcd restore procedure, because it goes against documentation guidelines of avoiding parenthesis. It also improves the technical description of the CSRs mentioned at that step.

Version(s):
4.16,4.15, 4.14

Issue:
https://issues.redhat.com/browse/OCPBUGS-31247

Link to docs preview:

https://73512--ocpdocs-pr.netlify.app/openshift-enterprise/latest/backup_and_restore/control_plane_backup_and_restore/disaster_recovery/scenario-2-restoring-cluster-state

QE review:

  • QE has approved this change.

Additional information:

(none)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ShaunaDiaz
Copy link
Contributor

/cherrypick enterprise-4.14

@ShaunaDiaz
Copy link
Contributor

/cherrypick enterprise-4.15

@ShaunaDiaz
Copy link
Contributor

/cherrypick enterprise-4.16

@openshift-cherrypick-robot

@ShaunaDiaz: #73512 failed to apply on top of branch "enterprise-4.14":

Applying: OCPBUGS-31247: Remove "(for user-provisioned installations)" reference for accepting CSRs on etcd restore procedure
Using index info to reconstruct a base tree...
M	modules/dr-restoring-cluster-state.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/dr-restoring-cluster-state.adoc
CONFLICT (content): Merge conflict in modules/dr-restoring-cluster-state.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCPBUGS-31247: Remove "(for user-provisioned installations)" reference for accepting CSRs on etcd restore procedure
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@ShaunaDiaz: #73512 failed to apply on top of branch "enterprise-4.15":

Applying: OCPBUGS-31247: Remove "(for user-provisioned installations)" reference for accepting CSRs on etcd restore procedure
Using index info to reconstruct a base tree...
M	modules/dr-restoring-cluster-state.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/dr-restoring-cluster-state.adoc
CONFLICT (content): Merge conflict in modules/dr-restoring-cluster-state.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCPBUGS-31247: Remove "(for user-provisioned installations)" reference for accepting CSRs on etcd restore procedure
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@ShaunaDiaz: #73512 failed to apply on top of branch "enterprise-4.16":

Applying: OCPBUGS-31247: Remove "(for user-provisioned installations)" reference for accepting CSRs on etcd restore procedure
Using index info to reconstruct a base tree...
M	modules/dr-restoring-cluster-state.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/dr-restoring-cluster-state.adoc
CONFLICT (content): Merge conflict in modules/dr-restoring-cluster-state.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCPBUGS-31247: Remove "(for user-provisioned installations)" reference for accepting CSRs on etcd restore procedure
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ShaunaDiaz
Copy link
Contributor

Hey @palonsoro, it looks like all three branch cherry picks failed for #73512. You can create manual CPs that resolve the conflicts and then let me or the merge review team know and we can merge those up for you.

@ShaunaDiaz
Copy link
Contributor

/cherrypick enterprise-4.16

@openshift-cherrypick-robot

@ShaunaDiaz: new pull request created: #73610

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ShaunaDiaz
Copy link
Contributor

#73486 had unmerged cherry picks

@ShaunaDiaz
Copy link
Contributor

/cherrypick enterprise-4.15

@ShaunaDiaz
Copy link
Contributor

/cherrypick enterprise-4.14

@palonsoro
Copy link
Contributor Author

Thanks @ShaunaDiaz

@openshift-cherrypick-robot

@ShaunaDiaz: new pull request created: #73611

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@ShaunaDiaz: new pull request created: #73612

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants