Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] OBSDOCS-833 Logging 5.9.0 Release Notes #73530

Merged
merged 1 commit into from Apr 4, 2024
Merged

[DOCS] OBSDOCS-833 Logging 5.9.0 Release Notes #73530

merged 1 commit into from Apr 4, 2024

Conversation

shreyasiddhartha
Copy link
Contributor

@shreyasiddhartha shreyasiddhartha commented Mar 21, 2024 •
edited

Change type: Doc update; Logging 5.9.0 Release Notes

Doc JIRA: https://issues.redhat.com/browse/OBSDOCS-833

Fix Version: 4.13+

Doc Preview: https://73530--ocpdocs-pr.netlify.app/openshift-enterprise/latest/logging/logging_release_notes/logging-5-9-release-notes

SME Review: @periklis
QE Review: @kabirbhartiRH
Peer Review: @mburke5678

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 21, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 21, 2024 •
edited

🤖 Thu Apr 04 19:14:54 - Prow CI generated the docs preview:

https://73530--ocpdocs-pr.netlify.app/
https://73530--ocpdocs-pr.netlify.app/openshift-dedicated/latest/logging/logging_release_notes/logging-5-9-release-notes.html
https://73530--ocpdocs-pr.netlify.app/openshift-enterprise/latest/logging/logging_release_notes/logging-5-9-release-notes.html
https://73530--ocpdocs-pr.netlify.app/openshift-rosa/latest/logging/logging_release_notes/logging-5-9-release-notes.html

@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 2, 2024
libander
libander reviewed Apr 3, 2024
View reviewed changes
Copy link
Contributor

@libander libander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit re deprecation notice.

modules/logging-release-notes-5-9-0.adoc Outdated Show resolved Hide resolved
modules/logging-release-notes-5-9-0.adoc Show resolved Hide resolved
@kabirbhartiRH
Copy link

Please check if we need release notes for the below 5.9 epics
https://issues.redhat.com/browse/LOG-3527
https://issues.redhat.com/browse/LOG-4538
https://issues.redhat.com/browse/LOG-4754

@shreyasiddhartha
Copy link
Contributor Author

Please check if we need release notes for the below 5.9 epics https://issues.redhat.com/browse/LOG-3527 https://issues.redhat.com/browse/LOG-4538 https://issues.redhat.com/browse/LOG-4754

@kabirbhartiRH I have added the epics to release notes. PTAL. Thanks!

@kabirbhartiRH
Copy link

kabirbhartiRH commented Apr 4, 2024 •
edited by openshift-ci bot

@shreyasiddhartha
Below JIRA's are mentioned on docs but are not under errata (Not sure if they should be added?)
LOG-4810
LOG-4830
LOG-4881
LOG-4884
LOG-4897
LOG-4898
LOG-4938
LOG-4939
LOG-5192
LOG-5261
LOG-5048 (has no-rn label)

All above have 'Release Note Not required' set but also have 'Release note text' on them.

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 4, 2024
@shreyasiddhartha
Copy link
Contributor Author

shreyasiddhartha commented Apr 4, 2024 •
edited

@shreyasiddhartha Below JIRA's are mentioned on docs but are not under errata (Not sure if they should be added?) LOG-4810 LOG-4830 LOG-4881 LOG-4884 LOG-4897 LOG-4898 LOG-4938 LOG-4939 LOG-5192 LOG-5261 LOG-5048 (has no-rn label)

All above have 'Release Note Not required' set but also have 'Release note text' on them.

I'm removing the above JIRAs as, if it's set to "Release Note Not required", it need not be drafted. Most of the JIRAs are clones from previous z-stream releases where "Release Note Text" was updated in the JIRA as well as the docs, hence it's showing for 5.9 JIRAs as well. Thanks for pointing this out. :)

@kabirbhartiRH
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2024
periklis
periklis suggested changes Apr 4, 2024
View reviewed changes
Copy link

@periklis periklis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing https://issues.redhat.com/browse/LOG-5165 from log storage bug fixes.

@shreyasiddhartha
Copy link
Contributor Author

Missing https://issues.redhat.com/browse/LOG-5165 from log storage bug fixes.

@periklis The bug has "Release Note Type" set to "Release Note Not Required". Do you still want me to cover it? It was also covered in a z-stream release.

@periklis
Copy link

periklis commented Apr 4, 2024 •
edited

Missing https://issues.redhat.com/browse/LOG-5165 from log storage bug fixes.

@periklis The bug has "Release Note Type" set to "Release Note Not Required". Do you still want me to cover it? It was also covered in a z-stream release.

Yes please add this one here too. This was a small selector mistake on my side.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 4, 2024

New changes are detected. LGTM label has been removed.

@mburke5678 mburke5678 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 4, 2024
@mburke5678
Copy link
Contributor

@shreyasiddhartha A few nits. Otherwise LGTM

@shreyasiddhartha
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Apr 4, 2024
@abrennan89 abrennan89 added this to the Continuous Release milestone Apr 4, 2024
@abrennan89 abrennan89 self-assigned this Apr 4, 2024
@abrennan89 abrennan89 added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Apr 4, 2024
abrennan89
abrennan89 reviewed Apr 4, 2024
View reviewed changes
Copy link
Contributor

@abrennan89 abrennan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments for changes before merging

modules/logging-release-notes-5-9-0.adoc Outdated Show resolved Hide resolved
modules/logging-release-notes-5-9-0.adoc Outdated Show resolved Hide resolved
modules/logging-release-notes-5-9-0.adoc Outdated Show resolved Hide resolved
modules/logging-release-notes-5-9-0.adoc Outdated Show resolved Hide resolved
modules/logging-release-notes-5-9-0.adoc Outdated Show resolved Hide resolved
modules/logging-release-notes-5-9-0.adoc Outdated Show resolved Hide resolved
modules/logging-release-notes-5-9-0.adoc Outdated Show resolved Hide resolved
modules/logging-release-notes-5-9-0.adoc Outdated Show resolved Hide resolved
modules/logging-release-notes-5-9-0.adoc Show resolved Hide resolved
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 4, 2024

@shreyasiddhartha: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@abrennan89 abrennan89 added ok-to-merge and removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Apr 4, 2024
@abrennan89
Copy link
Contributor

/lgtm

@abrennan89 abrennan89 merged commit e81f7f2 into openshift:main Apr 4, 2024
2 checks passed
@abrennan89
Copy link
Contributor

/cherrypick enterprise-4.13

@abrennan89
Copy link
Contributor

/cherrypick enterprise-4.14

@abrennan89
Copy link
Contributor

/cherrypick enterprise-4.15

@abrennan89
Copy link
Contributor

/cherrypick enterprise-4.16

@openshift-cherrypick-robot
Copy link

@abrennan89: new pull request created: #74237

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 4, 2024
Merged
@openshift-cherrypick-robot
Copy link

@abrennan89: new pull request created: #74238

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 4, 2024
Merged
@openshift-cherrypick-robot
Copy link

@abrennan89: new pull request created: #74239

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 4, 2024
Merged
@openshift-cherrypick-robot
Copy link

@abrennan89: new pull request created: #74240

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@periklis periklis periklis requested changes

@mburke5678 mburke5678 mburke5678 left review comments

@abrennan89 abrennan89 abrennan89 left review comments

@libander libander libander left review comments

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

Assignees

@abrennan89 abrennan89

@kabirbhartiRH kabirbhartiRH

Labels
branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 ok-to-merge peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@shreyasiddhartha @ocpdocs-previewbot @kabirbhartiRH @periklis @mburke5678 @abrennan89 @openshift-cherrypick-robot @libander @ocpdocs-vale-bot