Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-30994: Removing bad hyphen and removing overlapping CPUs #73561

Merged
merged 1 commit into from Mar 25, 2024
Merged

OCPBUGS-30994: Removing bad hyphen and removing overlapping CPUs #73561

merged 1 commit into from Mar 25, 2024

Conversation

rohennes
Copy link
Contributor

@rohennes rohennes commented Mar 21, 2024 •
edited by JoeAldinger

OCPBUGS-30994: Fixing bad YAML and overlapping CPUs

Version(s):
4.12+

Issue:
https://issues.redhat.com/browse/OCPBUGS-30994

Link to docs preview:
https://73561--ocpdocs-pr.netlify.app/openshift-enterprise/latest/scalability_and_performance/cnf-low-latency-tuning.html#adjusting-nic-queues-with-the-performance-profile_cnf-master

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 21, 2024
@openshift-ci-robot
Copy link

@rohennes: This pull request references Jira Issue OCPBUGS-30994, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

OCPBUGS-30994: Fixing bad YAML and overlapping CPUs

Version(s):
4.12+

Issue:
https://issues.redhat.com/browse/OCPBUGS-30994

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 21, 2024
@ocpdocs-previewbot
Copy link

🤖 Thu Mar 21 16:43:46 - Prow CI generated the docs preview:
https://73561--ocpdocs-pr.netlify.app

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 21, 2024

@rohennes: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

@rohennes: This pull request references Jira Issue OCPBUGS-30994, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

OCPBUGS-30994: Fixing bad YAML and overlapping CPUs

Version(s):
4.12+

Issue:
https://issues.redhat.com/browse/OCPBUGS-30994

Link to docs preview:
https://73561--ocpdocs-pr.netlify.app/openshift-enterprise/latest/scalability_and_performance/cnf-low-latency-tuning.html#adjusting-nic-queues-with-the-performance-profile_cnf-master

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@aireilly aireilly requested a review from midu16 March 21, 2024 16:59
midu16
midu16 approved these changes Mar 21, 2024
View reviewed changes
Copy link

@midu16 midu16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me.

@mrniranjan
Copy link

looks good to me

@rohennes
Copy link
Contributor Author

/label peer-review-needed
/label telco

@openshift-ci openshift-ci bot added peer-review-needed Signifies that the peer review team needs to review this PR telco Label for all Telco PRs labels Mar 22, 2024
@bburt-rh bburt-rh added peer-review-in-progress Signifies that the peer review team is reviewing this PR branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 22, 2024
@bburt-rh bburt-rh added this to the Continuous Release milestone Mar 22, 2024
bburt-rh
bburt-rh approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@bburt-rh bburt-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@bburt-rh bburt-rh added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Mar 22, 2024
@rohennes
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Mar 25, 2024
@JoeAldinger JoeAldinger added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Mar 25, 2024
@JoeAldinger JoeAldinger self-assigned this Mar 25, 2024
@JoeAldinger JoeAldinger merged commit 404b1ea into openshift:main Mar 25, 2024
2 checks passed
@openshift-ci-robot
Copy link

@rohennes: Jira Issue OCPBUGS-30994 is in an unrecognized state (Verified) and will not be moved to the MODIFIED state.

In response to this:

OCPBUGS-30994: Fixing bad YAML and overlapping CPUs

Version(s):
4.12+

Issue:
https://issues.redhat.com/browse/OCPBUGS-30994

Link to docs preview:
https://73561--ocpdocs-pr.netlify.app/openshift-enterprise/latest/scalability_and_performance/cnf-low-latency-tuning.html#adjusting-nic-queues-with-the-performance-profile_cnf-master

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@JoeAldinger
Copy link
Contributor

/cherrypick enterprise-4.16

@JoeAldinger
Copy link
Contributor

/cherrypick enterprise-4.15

@JoeAldinger
Copy link
Contributor

/cherrypick enterprise-4.14

@JoeAldinger
Copy link
Contributor

/cherrypick enterprise-4.13

@JoeAldinger
Copy link
Contributor

/cherrypick enterprise-4.12

@openshift-ci-robot
Copy link

@rohennes: Jira Issue OCPBUGS-30994 is in an unrecognized state (Verified) and will not be moved to the MODIFIED state.

In response to this:

OCPBUGS-30994: Fixing bad YAML and overlapping CPUs

Version(s):
4.12+

Issue:
https://issues.redhat.com/browse/OCPBUGS-30994

Link to docs preview:
https://73561--ocpdocs-pr.netlify.app/openshift-enterprise/latest/scalability_and_performance/cnf-low-latency-tuning.html#adjusting-nic-queues-with-the-performance-profile_cnf-master

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot
Copy link

@JoeAldinger: new pull request created: #73673

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 25, 2024
Merged
@openshift-cherrypick-robot
Copy link

@JoeAldinger: new pull request created: #73674

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Mar 25, 2024
Merged
Merged
@openshift-cherrypick-robot
Copy link

@JoeAldinger: new pull request created: #73675

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 25, 2024
Merged
@openshift-cherrypick-robot
Copy link

@JoeAldinger: new pull request created: #73676

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@JoeAldinger: new pull request created: #73677

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 25, 2024
Merged
@JoeAldinger JoeAldinger removed their assignment Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@midu16 midu16 midu16 approved these changes

@bburt-rh bburt-rh bburt-rh approved these changes

Assignees
No one assigned
Labels
branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files. telco Label for all Telco PRs
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@rohennes @openshift-ci-robot @ocpdocs-previewbot @mrniranjan @JoeAldinger @openshift-cherrypick-robot @midu16 @bburt-rh