Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-29005: Adding reference to grandmaster clocks #73618

Merged
merged 1 commit into from
Mar 26, 2024
Merged

OCPBUGS-29005: Adding reference to grandmaster clocks #73618

merged 1 commit into from
Mar 26, 2024

Conversation

rohennes
Copy link
Contributor

@rohennes rohennes commented Mar 22, 2024 •
edited

OCPBUGS-29005: Adding missing reference to grandmaster clocks

Version(s):
4.14+

Issue:
https://issues.redhat.com/browse/OCPBUGS-29005

Link to docs preview:
https://73618--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/ptp/using-ptp-events.html#cnf-about-ptp-and-clock-synchronization_using-ptp-hardware-fast-events-framework

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 22, 2024
@openshift-ci-robot
Copy link

@rohennes: This pull request references Jira Issue OCPBUGS-29005, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

OCPBUGS-29005: Adding missing reference to grandmaster clocks

Version(s):
4.14+

Issue:
https://issues.redhat.com/browse/OCPBUGS-29005

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 22, 2024
@ocpdocs-previewbot
Copy link

🤖 Fri Mar 22 12:10:19 - Prow CI generated the docs preview:
https://73618--ocpdocs-pr.netlify.app

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 22, 2024

@rohennes: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@javierpena
Copy link

Looks good to me, thanks for the fix!

@obochan-rh
Copy link

LGTM

1 similar comment
@hhassid
Copy link

hhassid commented Mar 24, 2024

LGTM

@rohennes
Copy link
Contributor Author

/label peer-review-needed
/label telco

@openshift-ci openshift-ci bot added peer-review-needed Signifies that the peer review team needs to review this PR telco Label for all Telco PRs labels Mar 25, 2024
mletalie
mletalie reviewed Mar 25, 2024
View reviewed changes
Copy link
Contributor

@mletalie mletalie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Mar 25, 2024
mletalie
mletalie reviewed Mar 25, 2024
View reviewed changes
Copy link
Contributor

@mletalie mletalie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done
/lgtm

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 25, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2024
@mletalie
Copy link
Contributor

Hello @rohennes,
Hope all is well! Just as a reminder, please make sure to check the "QE has approved this change" box in the ticket description (assuming one of the LGTM commentators is a QE). Thanks and good job!

@openshift-ci-robot
Copy link

@rohennes: This pull request references Jira Issue OCPBUGS-29005, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

OCPBUGS-29005: Adding missing reference to grandmaster clocks

Version(s):
4.14+

Issue:
https://issues.redhat.com/browse/OCPBUGS-29005

Link to docs preview:
https://73618--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/ptp/using-ptp-events.html#cnf-about-ptp-and-clock-synchronization_using-ptp-hardware-fast-events-framework

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rohennes
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Mar 25, 2024
@JoeAldinger JoeAldinger added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Mar 26, 2024
@JoeAldinger JoeAldinger self-assigned this Mar 26, 2024
@JoeAldinger JoeAldinger added this to the Continuous Release milestone Mar 26, 2024
@JoeAldinger JoeAldinger merged commit af50a88 into openshift:main Mar 26, 2024
2 checks passed
@openshift-ci-robot
Copy link

@rohennes: Jira Issue OCPBUGS-29005 is in an unrecognized state (Verified) and will not be moved to the MODIFIED state.

In response to this:

OCPBUGS-29005: Adding missing reference to grandmaster clocks

Version(s):
4.14+

Issue:
https://issues.redhat.com/browse/OCPBUGS-29005

Link to docs preview:
https://73618--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/ptp/using-ptp-events.html#cnf-about-ptp-and-clock-synchronization_using-ptp-hardware-fast-events-framework

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@JoeAldinger
Copy link
Contributor

/cherrypick enterprise-4.16

@JoeAldinger
Copy link
Contributor

/cherrypick enterprise-4.15

@JoeAldinger
Copy link
Contributor

/cherrypick enterprise-4.14

@openshift-cherrypick-robot
Copy link

@JoeAldinger: new pull request created: #73728

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Mar 26, 2024
Merged
Merged
@openshift-cherrypick-robot
Copy link

@JoeAldinger: new pull request created: #73729

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 26, 2024
Merged
@openshift-cherrypick-robot
Copy link

@JoeAldinger: new pull request created: #73730

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mletalie mletalie mletalie left review comments

Assignees

@JoeAldinger JoeAldinger

@mletalie mletalie

Labels
branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. telco Label for all Telco PRs
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@rohennes @openshift-ci-robot @ocpdocs-previewbot @javierpena @obochan-rh @hhassid @mletalie @JoeAldinger @openshift-cherrypick-robot