RHDEVDOCS-5627: Adds missing 4.15 release note for builds #73708

opayne1 · 2024-03-25T19:01:20Z

Adds missing 4.15 release note for builds

Version(s):
4.15

Issue:
https://issues.redhat.com/browse/RHDEVDOCS-5627

Link to docs preview:
https://73708--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-15-release-notes#ocp-4-15-administrator-perspective

QE review:

QE has approved this change.

Additional information:
This will need change management
@invincibleJai @jerolimov @Preeticp @joaedwar

openshift-ci-robot · 2024-03-25T19:01:24Z

@opayne1: This pull request references RHDEVDOCS-5627 which is a valid jira issue.

In response to this:

Adds missing 4.15 release note for builds

Version(s):
4.15

Issue:
https://issues.redhat.com/browse/RHDEVDOCS-5627

Link to docs preview:

QE review:

QE has approved this change.

Additional information:
This will need change management
@invincibleJai @jerolimov @Preeticp @joaedwar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ocpdocs-previewbot · 2024-03-25T19:06:39Z

🤖 Tue Apr 30 18:29:06 - Prow CI generated the docs preview:

https://73708--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-15-release-notes.html

openshift-ci-robot · 2024-03-25T19:08:39Z

@opayne1: This pull request references RHDEVDOCS-5627 which is a valid jira issue.

In response to this:

Adds missing 4.15 release note for builds

Version(s):
4.15

Issue:
https://issues.redhat.com/browse/RHDEVDOCS-5627

Link to docs preview:
https://73708--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-15-release-notes#ocp-4-15-administrator-perspective

QE review:

QE has approved this change.

Additional information:
This will need change management
@invincibleJai @jerolimov @Preeticp @joaedwar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

buildbricks · 2024-03-25T19:44:59Z

release_notes/ocp-4-15-release-notes.adoc

@@ -184,6 +184,7 @@ This release introduces the following updates to the *Administrator* perspective

 * Enable and disable the tailing to Pod log viewer to minimize load time.
 * View recommended values for `VerticalPodAutoscaler` on the *Deployment* page.
+* Opt-out of `BuildConfig` and `DeploymentConfigs` when a cluster does not have v1 builds.


I don't think I fully understand this.

Are we asking users to disable BuildConfig and DeploymentConfigs if the cluster lacks support for builds for Red Hat OpenShift 1.0?

Is "v1 builds" how we officially refer to it? Sorry, can't seem to find an example in the docs. I probably missed something.

Honestly I am not really sure I understand this completely either @joaedwar can you help weigh in on this?

Yeah @opayne1 I think I will ask/follow up with eng about this when they are back online. Would you have a screenshot of this handy?

Also, I think from the we should probably us enable or disable rather than opt-out , but I'll check if that is the case in the IBM style guide.

@joaedwar I just added a few updates to this. I am still not 100% on it. I do not have a screenshot on it at the moment.

Thanks @opayne1. That seems clear . I am just checking with QE to see what they say. Thank you for working on this :)

adambkaplan · 2024-03-28T15:19:42Z

release_notes/ocp-4-15-release-notes.adoc

@@ -184,6 +184,7 @@ This release introduces the following updates to the *Administrator* perspective

 * Enable and disable the tailing to Pod log viewer to minimize load time.
 * View recommended values for `VerticalPodAutoscaler` on the *Deployment* page.
+* Disable `BuildConfig` and `DeploymentConfigs` when a cluster does not have a `build.openshift.io/v1` API version.


DeploymentConfig is a separate API, controlled by a separate cluster capability (DeploymentConfig). If DeploymentConfig web console components are removed simply because the build.openshift.io API group is not present, this is a bug.

Thank you for reviewing @adambkaplan. So should this be added as a known issue, instead? I am not sure why we should disable these components.

@adambkaplan Just to elaborate the issue, we observed that when there is no build.openshift.io/v1` API version in the cluster, the DeployConfig does not work properly. We did a small spike to see that although the ReplicationController for the DC is getting created, still DC is not starting the pods. This hinted some underlining connection b/w the BC and DC.
But surely it may also be a bug. It would be great if we can ask someone from the respective team.

But surely it may also be a bug. It would be great if we can ask someone from the respective team.

This is absolutely a bug. Potentially related to (or fixed by) OCPBUGS-22956

Looks like someone wrote up text for that bug, but it didn't make it into the release notes. I have reached out to the writer working in this area for more information.

I will most likely update this PR with a note for OCPBUGS-22956 in the bug fixes section of the release notes based on what I find out.

Updated to include the bug fix.

adambkaplan · 2024-03-28T15:24:47Z

/assign @Lucifergene

Avik is the owner of the respective epic, ODC-7352

opayne1 · 2024-04-05T14:28:46Z

@joaedwar @Preeticp could you ack this PR? I am going to put it through the change management process and try and get this merged as soon as possible.

mwerner2113 · 2024-04-08T17:31:46Z

LGTM

cbippley · 2024-04-08T18:34:29Z

LGTM

opayne1 · 2024-04-09T12:36:29Z

Hi @sferich888 and @xltian! This PR adds a bug to the release notes that was missed when batching in bugs to the 4.15 release. Could you provide an ack for change management? Thanks!

buildbricks

lgtm

sferich888 · 2024-04-15T19:12:33Z

/lgtm

With that said we don't use ConfigObserver anywhere in our docs; but in this location (or update) so it may not be something customer understand or can parse if they read this update. In short it may be better to explain that the ConfigObserver is the CVO.

openshift-ci · 2024-04-26T17:31:14Z

New changes are detected. LGTM label has been removed.

psrna · 2024-04-29T06:38:33Z

lgtm

dfitzmau · 2024-04-29T14:12:01Z

/remove-label peer-review-needed

/label peer-review-in-progress

dfitzmau · 2024-04-29T14:29:59Z

Hi @opayne1 . WOuld you be OK to tick the QE Approved box? I think QE approved the PR?

Also, is a CM needed for this? The OCP Docs Manual is not very clear. The Peer-review checklist states:

openshift-ci-robot · 2024-04-29T14:30:43Z

@opayne1: This pull request references RHDEVDOCS-5627 which is a valid jira issue.

In response to this:

Adds missing 4.15 release note for builds

Version(s):
4.15

Issue:
https://issues.redhat.com/browse/RHDEVDOCS-5627

Link to docs preview:
https://73708--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-15-release-notes#ocp-4-15-administrator-perspective

QE review:

QE has approved this change.

Additional information:
This will need change management
@invincibleJai @jerolimov @Preeticp @joaedwar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

release_notes/ocp-4-15-release-notes.adoc

dfitzmau · 2024-04-29T14:41:48Z

/remove-label peer-review-in-progress

/label peer-review-done

openshift-ci · 2024-04-30T18:31:00Z

@opayne1: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

opayne1 added the branch/enterprise-4.15 label Mar 25, 2024

opayne1 added this to the Continuous Release milestone Mar 25, 2024

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 25, 2024

openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 25, 2024

buildbricks reviewed Mar 25, 2024

View reviewed changes

opayne1 force-pushed the RHDEVDOCS-5627 branch from 40482eb to f9da79c Compare March 27, 2024 15:26

adambkaplan reviewed Mar 28, 2024

View reviewed changes

openshift-ci bot assigned Lucifergene Mar 28, 2024

opayne1 force-pushed the RHDEVDOCS-5627 branch from f9da79c to 9bf1552 Compare April 1, 2024 15:05

buildbricks approved these changes Apr 9, 2024

View reviewed changes

openshift-ci bot assigned sferich888 Apr 15, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2024

opayne1 force-pushed the RHDEVDOCS-5627 branch from 9bf1552 to 3455d73 Compare April 26, 2024 17:30

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2024

opayne1 added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 29, 2024

openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 29, 2024

dfitzmau reviewed Apr 29, 2024

View reviewed changes

release_notes/ocp-4-15-release-notes.adoc Show resolved Hide resolved

openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Apr 29, 2024

opayne1 force-pushed the RHDEVDOCS-5627 branch from 3455d73 to aa6fe22 Compare April 29, 2024 18:49

RHDEVDOCS-5627: Adds missing 4.15 release note for builds

4e8b953

opayne1 force-pushed the RHDEVDOCS-5627 branch from aa6fe22 to 4e8b953 Compare April 30, 2024 18:24

opayne1 merged commit a2e8b6f into openshift:enterprise-4.15 May 2, 2024
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RHDEVDOCS-5627: Adds missing 4.15 release note for builds #73708

RHDEVDOCS-5627: Adds missing 4.15 release note for builds #73708

opayne1 commented Mar 25, 2024 •

edited

openshift-ci-robot commented Mar 25, 2024 •

edited by openshift-ci bot

ocpdocs-previewbot commented Mar 25, 2024 •

edited

openshift-ci-robot commented Mar 25, 2024 •

edited by openshift-ci bot

buildbricks Mar 25, 2024

opayne1 Mar 25, 2024

buildbricks Mar 25, 2024

buildbricks Mar 25, 2024

opayne1 Mar 27, 2024

buildbricks Mar 27, 2024

adambkaplan Mar 28, 2024

buildbricks Mar 28, 2024

Lucifergene Apr 1, 2024

adambkaplan Apr 1, 2024

opayne1 Apr 1, 2024

opayne1 Apr 1, 2024

adambkaplan commented Mar 28, 2024

opayne1 commented Apr 5, 2024

mwerner2113 commented Apr 8, 2024

cbippley commented Apr 8, 2024

opayne1 commented Apr 9, 2024

buildbricks left a comment

sferich888 commented Apr 15, 2024

openshift-ci bot commented Apr 26, 2024

psrna commented Apr 29, 2024

dfitzmau commented Apr 29, 2024

dfitzmau commented Apr 29, 2024

openshift-ci-robot commented Apr 29, 2024 •

edited by openshift-ci bot

dfitzmau commented Apr 29, 2024

openshift-ci bot commented Apr 30, 2024

RHDEVDOCS-5627: Adds missing 4.15 release note for builds #73708

RHDEVDOCS-5627: Adds missing 4.15 release note for builds #73708

Conversation

opayne1 commented Mar 25, 2024 • edited

openshift-ci-robot commented Mar 25, 2024 • edited by openshift-ci bot

ocpdocs-previewbot commented Mar 25, 2024 • edited

openshift-ci-robot commented Mar 25, 2024 • edited by openshift-ci bot

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adambkaplan commented Mar 28, 2024

opayne1 commented Apr 5, 2024

mwerner2113 commented Apr 8, 2024

cbippley commented Apr 8, 2024

opayne1 commented Apr 9, 2024

buildbricks left a comment

Choose a reason for hiding this comment

sferich888 commented Apr 15, 2024

openshift-ci bot commented Apr 26, 2024

psrna commented Apr 29, 2024

dfitzmau commented Apr 29, 2024

dfitzmau commented Apr 29, 2024

openshift-ci-robot commented Apr 29, 2024 • edited by openshift-ci bot

dfitzmau commented Apr 29, 2024

openshift-ci bot commented Apr 30, 2024

opayne1 commented Mar 25, 2024 •

edited

openshift-ci-robot commented Mar 25, 2024 •

edited by openshift-ci bot

ocpdocs-previewbot commented Mar 25, 2024 •

edited

openshift-ci-robot commented Mar 25, 2024 •

edited by openshift-ci bot

openshift-ci-robot commented Apr 29, 2024 •

edited by openshift-ci bot