Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-31451-rev: Revert vSphere instance support versions #74049

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

dfitzmau
Copy link
Contributor

@dfitzmau dfitzmau commented Apr 2, 2024

Version(s):
4.16 to 4.14

Issue:
https://issues.redhat.com/browse/OCPBUGS-31451

Link to docs preview:

  • SME has approved this change.
  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 2, 2024
@gcharot
Copy link

gcharot commented Apr 3, 2024

LGTM

@dfitzmau
Copy link
Contributor Author

dfitzmau commented Apr 3, 2024

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 3, 2024
Copy link

openshift-ci bot commented Apr 3, 2024

@dfitzmau: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@jldohmann jldohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jldohmann jldohmann added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 3, 2024
@duanwei33
Copy link

LGTM from storage QE side.

@dfitzmau
Copy link
Contributor Author

dfitzmau commented Apr 8, 2024

/label merge-review-needed

1 similar comment
@dfitzmau
Copy link
Contributor Author

dfitzmau commented Apr 8, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Apr 8, 2024
@skrthomas skrthomas added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Apr 8, 2024
@skrthomas skrthomas merged commit e9e26a6 into openshift:main Apr 8, 2024
2 checks passed
@skrthomas
Copy link
Contributor

/cherrypick enterprise-4.14

@skrthomas
Copy link
Contributor

/cherrypick enterprise-4.15

@skrthomas
Copy link
Contributor

/cherrypick enterprise-4.16

@openshift-cherrypick-robot

@skrthomas: #74049 failed to apply on top of branch "enterprise-4.14":

Applying: OCPBUGS-31451-rev: Revert vSphere instance support versions
Using index info to reconstruct a base tree...
M	modules/installation-vsphere-infrastructure.adoc
M	modules/vmware-csi-driver-reqs.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/vmware-csi-driver-reqs.adoc
CONFLICT (content): Merge conflict in modules/vmware-csi-driver-reqs.adoc
Auto-merging modules/installation-vsphere-infrastructure.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCPBUGS-31451-rev: Revert vSphere instance support versions
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@skrthomas: new pull request created: #74344

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@skrthomas: new pull request created: #74345

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants