Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS#31451-ocp-13: Added note about vSphere instance versions with… #74057

Merged
merged 1 commit into from
Apr 8, 2024
Merged

OCPBUGS#31451-ocp-13: Added note about vSphere instance versions with… #74057

merged 1 commit into from
Apr 8, 2024

Conversation

dfitzmau
Copy link
Contributor

@dfitzmau dfitzmau commented Apr 2, 2024 •
edited

@openshift-ci-robot
Copy link

@dfitzmau: No Jira issue with key ocp-13 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

… regards to upgrading clusters]

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

@dfitzmau: No Jira issue with key ocp-13 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Version(s):
4.13

Issue:

Link to docs preview:
https://74051--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_vsphere/installing-vsphere-installer-provisioned#installation-vsphere-infrastructure_installing-vsphere-installer-provisioned

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 2, 2024
@dfitzmau dfitzmau changed the title OCPBUGS-31451-ocp-13: Added note about vSphere instance versions with… OCPBUGS#31451-ocp-13: Added note about vSphere instance versions with… Apr 2, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 2, 2024 •
edited

🤖 Fri Apr 05 08:19:55 - Prow CI generated the docs preview:
https://74057--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@openshift-ci-robot
Copy link

@dfitzmau: No Jira issue with key ocp-13 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Version(s):
4.13

Issue:

Link to docs preview:
VMware vSphere infrastructure requirements

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

@dfitzmau: No Jira issue with key ocp-13 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Version(s):
4.13

Issue:

Link to docs preview:
VMware vSphere infrastructure requirements

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dfitzmau dfitzmau force-pushed the OCPBUGS-31451-ocp-13 branch 4 times, most recently from db0708f to 1a9dcb7 Compare April 3, 2024 09:48
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 3, 2024
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 3, 2024
@openshift-ci-robot
Copy link

@dfitzmau: No Jira issue with key ocp-13 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Version(s):
4.13

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

@dfitzmau: No Jira issue with key ocp-13 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Version(s):
4.13

Issue:

Link to docs preview:

[ ] SME has approved this change.
[ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 4, 2024
@gcharot
Copy link

gcharot commented Apr 4, 2024

LGTM

@dfitzmau
Copy link
Contributor Author

dfitzmau commented Apr 4, 2024

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 4, 2024
@openshift-ci-robot
Copy link

@dfitzmau: No Jira issue with key ocp-13 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Version(s):
4.13

Issue:
(https://issues.redhat.com/browse/OCPBUGS-31451)

Link to docs preview:

[ ] SME has approved this change.
[ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

@dfitzmau: No Jira issue with key ocp-13 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Version(s):
4.13

Issue:
https://issues.redhat.com/browse/OCPBUGS-31451

Link to docs preview:

[ ] SME has approved this change.
[ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mburke5678 mburke5678 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Apr 4, 2024
@mburke5678 mburke5678 added this to the Continuous Release milestone Apr 4, 2024
@mburke5678 mburke5678 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 4, 2024
@mburke5678
Copy link
Contributor

mburke5678 commented Apr 4, 2024 •
edited

@dfitzmau A few nits and one question about a missing module. Otherwise LGTM

This PR is only for 4.13, as there are other PRs for other versions, I believe?

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 5, 2024

@dfitzmau: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@duanwei33
Copy link

LGTM (from storage QE side)

@dfitzmau
Copy link
Contributor Author

dfitzmau commented Apr 8, 2024

/label merge-review-needed

1 similar comment
@dfitzmau
Copy link
Contributor Author

dfitzmau commented Apr 8, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Apr 8, 2024
@skrthomas skrthomas added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Apr 8, 2024
@skrthomas skrthomas merged commit 5fe8236 into openshift:enterprise-4.13 Apr 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mburke5678 mburke5678 mburke5678 left review comments

Assignees
No one assigned
Labels
branch/enterprise-4.13 merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dfitzmau @openshift-ci-robot @ocpdocs-previewbot @gcharot @mburke5678 @duanwei33 @skrthomas