Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSSM-6147 Add deprecation callout for automatic routes documentation #74299

Merged
merged 1 commit into from
Apr 22, 2024
Merged

OSSM-6147 Add deprecation callout for automatic routes documentation #74299

merged 1 commit into from
Apr 22, 2024

Conversation

gwynnemonahan
Copy link
Contributor

@gwynnemonahan gwynnemonahan commented Apr 5, 2024 •
edited

OSSM-6147 Add deprecation callout for automatic routes documentation

Version(s):
4.12+

Issue:
https://issues.redhat.com/browse/OSSM-6147

Link to docs preview:
https://74299--ocpdocs-pr.netlify.app/openshift-enterprise/latest/service_mesh/v2x/ossm-traffic-manage#ossm-auto-route_traffic-management

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 5, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 5, 2024 •
edited

🤖 Mon Apr 22 12:30:46 - Prow CI generated the docs preview:

https://74299--ocpdocs-pr.netlify.app/openshift-dedicated/latest/service_mesh/v2x/ossm-traffic-manage.html
https://74299--ocpdocs-pr.netlify.app/openshift-enterprise/latest/service_mesh/v2x/ossm-traffic-manage.html
https://74299--ocpdocs-pr.netlify.app/openshift-rosa/latest/service_mesh/v2x/ossm-traffic-manage.html

@gwynnemonahan gwynnemonahan force-pushed the OSSM-6147 branch 2 times, most recently from bdabc0a to 1f5bca7 Compare April 9, 2024 12:54
@mkralik3
Copy link

mkralik3 commented Apr 9, 2024

LGTM

@gwynnemonahan
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 9, 2024
@tmalove
Copy link
Contributor

tmalove commented Apr 9, 2024

/remove-label peer-review-needed
/label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 9, 2024
@tmalove
Copy link
Contributor

tmalove commented Apr 9, 2024

/remove-label peer-review-in-progress
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Apr 9, 2024
@gwynnemonahan gwynnemonahan force-pushed the OSSM-6147 branch 3 times, most recently from 097cbc4 to e708b82 Compare April 18, 2024 18:08
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 22, 2024

@gwynnemonahan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gwynnemonahan
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Apr 22, 2024
@bergerhoffer
Copy link
Contributor

/label merge-review-in-progress

@openshift-ci openshift-ci bot added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Apr 22, 2024
@bergerhoffer bergerhoffer added this to the Continuous Release milestone Apr 22, 2024
bergerhoffer
bergerhoffer reviewed Apr 22, 2024
View reviewed changes
Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for merging

@bergerhoffer bergerhoffer merged commit 7a454e6 into openshift:main Apr 22, 2024
3 checks passed
@bergerhoffer
Copy link
Contributor

/cherrypick enterprise-4.16

@bergerhoffer
Copy link
Contributor

/cherrypick enterprise-4.15

@bergerhoffer
Copy link
Contributor

/cherrypick enterprise-4.14

@bergerhoffer
Copy link
Contributor

/cherrypick enterprise-4.13

@bergerhoffer
Copy link
Contributor

/cherrypick enterprise-4.12

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 22, 2024
Merged
@openshift-cherrypick-robot
Copy link

@bergerhoffer: new pull request created: #74969

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 22, 2024
Merged
@openshift-cherrypick-robot
Copy link

@bergerhoffer: new pull request created: #74970

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 22, 2024
Merged
@openshift-cherrypick-robot
Copy link

@bergerhoffer: new pull request created: #74971

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@bergerhoffer: new pull request created: #74972

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Apr 22, 2024
Merged
Merged
@openshift-cherrypick-robot
Copy link

@bergerhoffer: new pull request created: #74973

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergerhoffer bergerhoffer bergerhoffer left review comments

Assignees
No one assigned
Labels
branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@gwynnemonahan @ocpdocs-previewbot @mkralik3 @tmalove @bergerhoffer @openshift-cherrypick-robot