RHDEVDOCS 5933 fix spec in configuring PAC #74504
Conversation
openshift-ci
bot
added
the
size/XS
|
🤖 Wed Apr 10 21:23:05 - Prow CI generated the docs preview: |
| @@ -6,7 +6,7 @@ | |||
| = Customizing {pac} configuration | |||
|
|
|||
| [role="_abstract"] | |||
| To customize {pac}, cluster administrators can configure the following parameters in the `TektonConfig` custom resource, in the `pipelinesAsCode.settings` spec: | |||
| To customize {pac}, cluster administrators can configure the following parameters in the `TektonConfig` custom resource, in the `platforms.openshift.pipelinesAsCode.settings` spec: | |||
There was a problem hiding this comment.
should we mention spec. also in start?
There was a problem hiding this comment.
Not really as the word "spec" implies it.
There was a problem hiding this comment.
Example of such use: https://docs.openshift.com/pipelines/1.14/create/remote-pipelines-tasks-resolvers.html#resolver-hub-config_remote-pipelines-tasks-resolvers
Other places do have "spec." but they call it "parameter".
It's a good question of consistency to raise on a higher level, I guess. I'll try to raise it. Meanwhile can we go on with this merge?
There was a problem hiding this comment.
I have raised it with other writers and the answers I got were generally in support of the way I did it
|
@mramendi: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
LGTM |
|
/label peer-review-needed |
openshift-ci
bot
added
the
peer-review-needed
|
/label peer-review-in-progress |
openshift-ci
bot
added
the
peer-review-in-progress
openshift-ci
bot
added
peer-review-done
|
/label merge-review-needed |
openshift-ci
bot
added
the
merge-review-needed
|
/lgtm |
kcarmichael08
added
peer-review-in-progress
|
/cherrypick pipelines-docs-1.11 |
|
/cherrypick pipelines-docs-1.12 |
|
/cherrypick pipelines-docs-1.13 |
|
/cherrypick pipelines-docs-1.14 |
|
@kcarmichael08: new pull request created: #74768 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@kcarmichael08: new pull request created: #74769 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@kcarmichael08: new pull request created: #74770 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick pipelines-docs-1.14 |
|
@kcarmichael08: new pull request created: #74771 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
kcarmichael08
removed
the
peer-review-in-progress
Version(s):
please cp to pipelines-docs-1.11, pipelines-docs-1.12, pipelines-docs-1.13, pipelines-docs-1.14
Issue:
RHDEVDOCS 5933
Link to docs preview:
https://74504--ocpdocs-pr.netlify.app/openshift-pipelines/latest/pac/install-config-pipelines-as-code.html#customizing-pipelines-as-code-configuration_install-config-pipelines-as-code
QE review:
Additional information: