[CMP-2336]Compliance Operator 1.4.1 Bugs #74715
Conversation
openshift-ci
bot
added
the
size/M
|
🤖 Fri Apr 19 12:17:34 - Prow CI generated the docs preview: |
|
@rhmdnd @yuumasato @Vincent056 your SME review desired. |
|
@xiaojiey @BhargaviGudi your QE review desired please. |
GroceryBoyJr
force-pushed
the
cmp-2336
branch
3 times, most recently
from
607ad56
to
c5b4005
Compare
|
/retest |
1 similar comment
|
/retest |
|
/label peer-review-needed |
openshift-ci
bot
added
the
peer-review-needed
|
/label peer-review-in-progress |
openshift-ci
bot
added
the
peer-review-in-progress
|
@GroceryBoyJr overall this looks pretty good to me. I have some fairly minor style suggestions in a few places. You did a very good job writing the bug fixes so they all have the same structure. In a few places, I think changing the language to past tense helps more clearly present the previous behavior versus the new behavior. Apart from that, it looks like the QA and SME review are still required before the PR can continue on in the official review process. I am still being onboarded for the peer review process, so I will also ask @bburt-rh to give this a quick looks as well. |
security/compliance_operator/compliance-operator-release-notes.adoc
Outdated
Show resolved
Hide resolved
security/compliance_operator/compliance-operator-release-notes.adoc
Outdated
Show resolved
Hide resolved
security/compliance_operator/compliance-operator-release-notes.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Made a few extra edits.
Also, @rh-tokeefe - a SME review is not required -- only QE approval. It's the writer's call whether or not to have a SME review the PR.
security/compliance_operator/compliance-operator-release-notes.adoc
Outdated
Show resolved
Hide resolved
security/compliance_operator/compliance-operator-release-notes.adoc
Outdated
Show resolved
Hide resolved
security/compliance_operator/compliance-operator-release-notes.adoc
Outdated
Show resolved
Hide resolved
|
/remove-label peer-review-in-progress |
openshift-ci
bot
removed
peer-review-in-progress
security/compliance_operator/compliance-operator-release-notes.adoc
Outdated
Show resolved
Hide resolved
security/compliance_operator/compliance-operator-release-notes.adoc
Outdated
Show resolved
Hide resolved
security/compliance_operator/compliance-operator-release-notes.adoc
Outdated
Show resolved
Hide resolved
security/compliance_operator/compliance-operator-release-notes.adoc
Outdated
Show resolved
Hide resolved
|
@GroceryBoyJr Made some nit comments for your consideration. I haven't merged because the advisory doesn't appear to be Shipped Live yet and I didn't want to break your embargo. Please let me know when ready to merge. TY! |
|
New changes are detected. LGTM label has been removed. |
|
@GroceryBoyJr: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/remove-label merge-review-in-progress |
openshift-ci
bot
removed
the
merge-review-in-progress
|
/cherrypick enterprise-4.12 |
|
/cherrypick enterprise-4.13 |
|
/cherrypick enterprise-4.14 |
|
/cherrypick enterprise-4.15 |
|
/cherrypick enterprise-4.16 |
|
@ShaunaDiaz: new pull request created: #74879 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@ShaunaDiaz: new pull request created: #74880 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@ShaunaDiaz: new pull request created: #74881 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@ShaunaDiaz: new pull request created: #74882 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@ShaunaDiaz: new pull request created: #74883 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Version(s): Branched from main but goes to 4.12+. Compliance Operator updates apply to all supported OCP branches.
Issue: Compliance Operator 1.4.1 update release notes https://issues.redhat.com/browse/CMP-2336
Link to docs preview: https://74715--ocpdocs-pr.netlify.app/openshift-enterprise/latest/security/compliance_operator/compliance-operator-release-notes.html
QE review:
Additional information: