Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-32490: Removed OCI steps from ABI docs #74910

Merged
merged 1 commit into from
May 3, 2024
Merged

OCPBUGS-32490: Removed OCI steps from ABI docs #74910

merged 1 commit into from
May 3, 2024

Conversation

dfitzmau
Copy link
Contributor

@dfitzmau dfitzmau commented Apr 19, 2024 •
edited

MERGE REVIEWER: This PR removes content that is now placed in the Oracle docs. They released their docs yesterday so the OCI links in my doc are now live.

Version(s):
4.14 to 4.16

Issue:
https://issues.redhat.com/browse/OCPBUGS-32490

Link to docs preview:
Agent-based Installer

  • SME has approved this change.
  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 19, 2024
@openshift-ci-robot
Copy link

@dfitzmau: This pull request references Jira Issue OCPBUGS-32490, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 19, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 19, 2024 •
edited

🤖 Fri May 03 09:11:55 - Prow CI generated the docs preview:

https://74910--ocpdocs-pr.netlify.app/
https://74910--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_oci/installing-oci-agent-based-installer.html
https://74910--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_oci/installing-oci-assisted-installer.html

@dfitzmau dfitzmau force-pushed the OCPBUGS-32490 branch 4 times, most recently from e54583d to 8c24a7a Compare April 22, 2024 09:18
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 22, 2024
@dfitzmau dfitzmau force-pushed the OCPBUGS-32490 branch 2 times, most recently from 6f59cc0 to be074c7 Compare April 22, 2024 10:05
@dfitzmau dfitzmau force-pushed the OCPBUGS-32490 branch 10 times, most recently from c266475 to 80563c7 Compare April 29, 2024 11:56
pawanpinjarkar
pawanpinjarkar reviewed Apr 29, 2024
View reviewed changes
Copy link

@pawanpinjarkar pawanpinjarkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good /lgtm

@dfitzmau
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 30, 2024
@mburke5678 mburke5678 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Apr 30, 2024
@openshift-ci-robot
Copy link

@dfitzmau: This pull request references Jira Issue OCPBUGS-32490, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

MERGE REVIEWER: This PR removes content that is now placed in the Oracle docs. They released their docs yesterday so the OCI links in my doc are now live.

Version(s):
4.14 to 4.16

Issue:
https://issues.redhat.com/browse/OCPBUGS-32490

Link to docs preview:
Agent-based Installer

  • SME has approved this change.
  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dfitzmau
Copy link
Contributor Author

dfitzmau commented May 2, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label May 2, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 2, 2024
@jldohmann jldohmann added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label May 2, 2024
jldohmann
jldohmann reviewed May 2, 2024
View reviewed changes
Copy link
Contributor

@jldohmann jldohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! a couple of minor nits before merge, also your PR needs a rebase

installing/installing_oci/installing-oci-agent-based-installer.adoc Outdated Show resolved Hide resolved
installing/installing_oci/installing-oci-agent-based-installer.adoc Outdated Show resolved Hide resolved
modules/running-cluster-oci-agent-based.adoc
* Image type: *QCOW2*

. After the image imports, go to the *Edit image capabilities* setting and ensure that only `UEFI_64` is selected for the *Firmware* field.
. Upload the agent ISO image to Oracle’s default Object Storage bucket and import the agent ISO image as a custom image to this bucket. Ensure you that you configure the custom image to boot in Unified Extensible Firmware Interface (UEFI) mode. For more information, see link:https://docs.oracle.com/iaas/Content/openshift-on-oci/installing-agent-image-creation.htm[Creating the {product-title} ISO Image (Oracle documentation)].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
. Upload the agent ISO image to Oracle’s default Object Storage bucket and import the agent ISO image as a custom image to this bucket. Ensure you that you configure the custom image to boot in Unified Extensible Firmware Interface (UEFI) mode. For more information, see link:https://docs.oracle.com/iaas/Content/openshift-on-oci/installing-agent-image-creation.htm[Creating the {product-title} ISO Image (Oracle documentation)].
. Upload the agent ISO image to Oracle’s default Object Storage bucket and import the agent ISO image as a custom image to this bucket. Ensure you that you configure the custom image to boot in Unified Extensible Firmware Interface (UEFI) mode. For more information, see link:https://docs.oracle.com/iaas/Content/openshift-on-oci/installing-agent-image-creation.htm[Creating the {product-title} Discovery ISO Image (Oracle documentation)].

Copy link
Contributor Author

@dfitzmau dfitzmau May 3, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "discovery" ISO image is affiliated with the Assisted Installer and not the Agent-based Installer, so I'll drop this update.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotcha, sounds good 👍

@jldohmann jldohmann added this to the Continuous Release milestone May 2, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 3, 2024
@dfitzmau dfitzmau force-pushed the OCPBUGS-32490 branch 2 times, most recently from 3c3ed80 to a934292 Compare May 3, 2024 08:38
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 3, 2024

@dfitzmau: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jldohmann jldohmann merged commit 6d3526f into openshift:main May 3, 2024
3 checks passed
@openshift-ci-robot
Copy link

@dfitzmau: Jira Issue OCPBUGS-32490 is in an unrecognized state (Verified) and will not be moved to the MODIFIED state.

In response to this:

MERGE REVIEWER: This PR removes content that is now placed in the Oracle docs. They released their docs yesterday so the OCI links in my doc are now live.

Version(s):
4.14 to 4.16

Issue:
https://issues.redhat.com/browse/OCPBUGS-32490

Link to docs preview:
Agent-based Installer

  • SME has approved this change.
  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jldohmann
Copy link
Contributor

/cherrypick enterprise-4.16

@jldohmann
Copy link
Contributor

/cherrypick enterprise-4.15

@jldohmann
Copy link
Contributor

/cherrypick enterprise-4.14

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 3, 2024
Merged
@openshift-cherrypick-robot
Copy link

@jldohmann: new pull request created: #75500

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@jldohmann: new pull request created: #75501

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced May 3, 2024
Merged
Merged
@openshift-cherrypick-robot
Copy link

@jldohmann: new pull request created: #75502

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jldohmann jldohmann removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jldohmann jldohmann jldohmann left review comments

@pawanpinjarkar pawanpinjarkar pawanpinjarkar left review comments

@mburke5678 mburke5678 mburke5678 left review comments

@snarayan-redhat snarayan-redhat snarayan-redhat left review comments

Assignees
No one assigned
Labels
branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@dfitzmau @openshift-ci-robot @ocpdocs-previewbot @mburke5678 @mhanss @jldohmann @openshift-cherrypick-robot @pawanpinjarkar @snarayan-redhat @openshift-merge-robot