Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enterprise-4.14] OBSDOCS-845 - Logging API Reference Updates #74924

Open
wants to merge 1 commit into
base: enterprise-4.14
Choose a base branch
from

Conversation

libander
Copy link
Contributor

@libander libander commented Apr 20, 2024

Version(s): 4.14

Issue: OBSDOCS-845

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
Logging Version | Supported OCP Versions Matrix
5.9 | 4.15, 4.14, 4.13
5.8 | 4.12, 4.13, 4.14, 4.15
5.7 | 4.12, 4.13, 4.14
5.6 | 4.12, 4.13

PRs by branch:
#74925
#74924
#74923
#74922

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 20, 2024
@libander libander changed the title OBSDOCS-845 - Logging API Reference Updates [Enterprise-4.14] OBSDOCS-845 - Logging API Reference Updates Apr 20, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 20, 2024

🤖 Fri Apr 26 04:44:29 - Prow CI generated the docs preview:

https://74924--ocpdocs-pr.netlify.app/

@libander
Copy link
Contributor Author

@anpingli / @kabirbhartiRH - lgtm please.

@libander
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 22, 2024
@anpingli
Copy link

Why don't we add 5.9 Logging API reference?

@GroceryBoyJr
Copy link
Contributor

GroceryBoyJr commented Apr 23, 2024

/assign @GroceryBoyJr

@GroceryBoyJr
Copy link
Contributor

/remove-label peer-review-needed
/label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 23, 2024
@libander
Copy link
Contributor Author

Why don't we add 5.9 Logging API reference?

Accidentally omitted from the topic map, good catch thank you!

@anpingli
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2024
Copy link

openshift-ci bot commented Apr 25, 2024

New changes are detected. LGTM label has been removed.

@libander libander force-pushed the OBSDOCS-845-4.14 branch 2 times, most recently from b77873e to d92234e Compare April 26, 2024 04:26
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 26, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 26, 2024
Copy link

openshift-ci bot commented Apr 26, 2024

@libander: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@GroceryBoyJr GroceryBoyJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For information on review for these files, look to PR #74922

These files are all nearly identical to the ones found in that PR and will be re-created by automation once the desired corrections have been made. Here are the search strings used to find the errors in these files:

explicitly for the
application logs that
logs to allow
profile based on:
Custom provides
the pods are scheduled on.
events will be
the mode
buffer plugin to
Flush operations can
(Which must be

@GroceryBoyJr
Copy link
Contributor

/label peer-review-done
/remove-label peer-review-in-progress
/unassign GroceryBoyJr

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
peer-review-done Signifies that the peer review team has reviewed this PR size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants