Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSDOCS-10396:ANP audit logging #75310

Merged
merged 1 commit into from
Jun 11, 2024
Merged

OSDOCS-10396:ANP audit logging #75310

merged 1 commit into from
Jun 11, 2024

Conversation

JoeAldinger
Copy link
Contributor

@JoeAldinger JoeAldinger commented Apr 29, 2024 •
edited

Version(s):
4.16

Issue:
https://issues.redhat.com/browse/OSDOCS-10396

Link to docs preview:
Logging preview
ANP vs Netpol table
ROSA
Dedicated

QE review:

  • QE has approved this change.

Additional information:

  1. moves networking docs for ANP and BANP to ROSA and dedicated
  2. Creates Network security directory
  3. Adds new table for (B)ANP and Netpol
  4. Bulk of content is moving and reorganizing the logging assembly to include (B)ANP.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 29, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 29, 2024 •
edited by openshift-ci bot

@JoeAldinger: This pull request references OSDOCS-10396 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 29, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 29, 2024 •
edited by openshift-ci bot

@JoeAldinger: This pull request references OSDOCS-10396 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):
4.16

Issue:
https://issues.redhat.com/browse/OSDOCS-10396

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@JoeAldinger JoeAldinger added this to the Planned for 4.16 GA milestone Apr 29, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 29, 2024 •
edited

🤖 Tue Jun 11 18:03:46 - Prow CI generated the docs preview:
https://75310--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@JoeAldinger JoeAldinger force-pushed the OSDOCS-10396 branch 2 times, most recently from 88b76c6 to 304d721 Compare April 30, 2024 21:23
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 30, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 1, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 2, 2024 •
edited by openshift-ci bot

@JoeAldinger: This pull request references OSDOCS-10396 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):
4.16

Issue:
https://issues.redhat.com/browse/OSDOCS-10396

Link to docs preview:
75310--ocpdocs-pr.netlify.app
75310--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/openshift_network_security/AdminNetworkPolicy/logging-anp-policy.html
75310--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/openshift_network_security/AdminNetworkPolicy/ovn-k-anp.html
75310--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/openshift_network_security/AdminNetworkPolicy/ovn-k-banp.html
75310--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/zero-trust-networking.html
75310--ocpdocs-pr.netlify.app/openshift-rosa/latest/networking/openshift_network_security/AdminNetworkPolicy/ovn-k-anp.html
75310--ocpdocs-pr.netlify.app/openshift-rosa/latest/networking/openshift_network_security/AdminNetworkPolicy/ovn-k-banp.html

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tssurya
Copy link

tssurya commented May 16, 2024

/assign @tssurya

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 21, 2024 •
edited by openshift-ci bot

@JoeAldinger: This pull request references OSDOCS-10396 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

Version(s):
4.16

Issue:
https://issues.redhat.com/browse/OSDOCS-10396

Link to docs preview:
Logging preview

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 21, 2024 •
edited by openshift-ci bot

@JoeAldinger: This pull request references OSDOCS-10396 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

Version(s):
4.16

Issue:
https://issues.redhat.com/browse/OSDOCS-10396

Link to docs preview:
Logging preview
ANP vs Netpol table

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@JoeAldinger JoeAldinger force-pushed the OSDOCS-10396 branch 2 times, most recently from e92e39a to cbc8b6f Compare May 21, 2024 12:56
tssurya
tssurya suggested changes Jun 11, 2024
View reviewed changes
modules/nw-anp-audit-logging-concept.adoc Outdated Show resolved Hide resolved
modules/nw-anp-audit-logging-concept.adoc Outdated Show resolved Hide resolved
modules/nw-anp-audit-logging-concept.adoc Outdated Show resolved Hide resolved
modules/nw-anp-audit-logging-concept.adoc Outdated Show resolved Hide resolved
modules/nw-anp-audit-logging-concept.adoc Outdated Show resolved Hide resolved
modules/nw-banp-audit-logging-concept.adoc Outdated Show resolved Hide resolved
modules/nw-banp-audit-logging-concept.adoc Outdated Show resolved Hide resolved
modules/nw-banp-audit-logging-concept.adoc Outdated Show resolved Hide resolved
modules/nw-banp-audit-logging-concept.adoc Outdated Show resolved Hide resolved
modules/nw-banp-audit-logging-concept.adoc Outdated Show resolved Hide resolved
tssurya
tssurya suggested changes Jun 11, 2024
View reviewed changes
modules/nw-anp-audit-logging-concept.adoc Outdated Show resolved Hide resolved
modules/nw-anp-audit-logging-concept.adoc Outdated Show resolved Hide resolved
modules/nw-anp-audit-logging-concept.adoc Outdated Show resolved Hide resolved
modules/nw-anp-audit-logging-concept.adoc Outdated Show resolved Hide resolved
tssurya
tssurya approved these changes Jun 11, 2024
View reviewed changes
Copy link

@tssurya tssurya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Great job @JoeAldinger !!
I guess rest we will deal with later as and when it comes. I'd recommend a full proof reading session for the 3 of us together ones docs merge. We should block out an hour for this (since there was many back-forth + I only reviewed iterate changes pushed)

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 11, 2024 •
edited by openshift-ci bot

@JoeAldinger: This pull request references OSDOCS-10396 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

Version(s):
4.16

Issue:
https://issues.redhat.com/browse/OSDOCS-10396

Link to docs preview:
Logging preview
ANP vs Netpol table
ROSA
Dedicated

QE review:

  • QE has approved this change.

Additional information:

  1. moves networking docs for ANP and BANP to ROSA and dedicated
  2. Creates Network security directory
  3. Adds new table for (B)ANP and Netpol
  4. Bulk of content is moving and reorganizing the logging assembly to include (B)ANP.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@JoeAldinger
OSDOCS-10396:ANP audit logging
d77fbdb 
in-flight restructure of (B)ANP loggin

fixing xrefs and removing the assembly file for (B)ANP

adds example outputs
@asood-rh
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 11, 2024

@JoeAldinger: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@JoeAldinger JoeAldinger merged commit cc87c30 into openshift:main Jun 11, 2024
3 checks passed
@JoeAldinger
Copy link
Contributor Author

/cherrypick enterprise-4.16

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 11, 2024
Merged
@openshift-cherrypick-robot
Copy link

@JoeAldinger: new pull request created: #77321

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asood-rh asood-rh asood-rh left review comments

@bscott-rh bscott-rh bscott-rh left review comments

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

@tssurya tssurya tssurya approved these changes

Assignees

@tssurya tssurya

@asood-rh asood-rh

Labels
branch/enterprise-4.16 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Planned for 4.16 GA
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@JoeAldinger @openshift-ci-robot @ocpdocs-previewbot @tssurya @asood-rh @openshift-cherrypick-robot @bscott-rh @ocpdocs-vale-bot @openshift-merge-robot