Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OBSDOCS-1009 List MS Teams as a supported receiver for monitoring alerts #75483

Merged
merged 1 commit into from
May 9, 2024
Merged

OBSDOCS-1009 List MS Teams as a supported receiver for monitoring alerts #75483

merged 1 commit into from
May 9, 2024

Conversation

eromanova97
Copy link
Contributor

@eromanova97 eromanova97 commented May 3, 2024 •
edited

Version(s): enterprise-4.15 and later

Issue: OBSDOCS-1009

Links to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 3, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented May 3, 2024 •
edited

🤖 Mon May 06 07:17:49 - Prow CI generated the docs preview:

https://75483--ocpdocs-pr.netlify.app/openshift-dedicated/latest/observability/monitoring/managing-alerts.html
https://75483--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/monitoring/managing-alerts.html
https://75483--ocpdocs-pr.netlify.app/openshift-enterprise/latest/post_installation_configuration/configuring-alert-notifications.html
https://75483--ocpdocs-pr.netlify.app/openshift-rosa/latest/observability/monitoring/managing-alerts.html

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 6, 2024

@eromanova97: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@juzhao
Copy link

juzhao commented May 7, 2024

/lgtm

just NOTE:
OCP 4.15 and 4.16 use alertmanager 0.26.0, from below information, summary requires Alertmanager >= 0.27.0, other fields are since 0.26.0

$ oc explain alertmanagerconfig.spec.receivers.msteamsConfigs
GROUP:      monitoring.coreos.com
KIND:       AlertmanagerConfig
VERSION:    v1beta1

FIELD: msteamsConfigs <[]Object>

DESCRIPTION:
    List of MSTeams configurations. It requires Alertmanager >= 0.26.0.
    MSTeamsConfig configures notifications via Microsoft Teams. It requires
    Alertmanager >= 0.26.0.
    
FIELDS:
  httpConfig	<Object>
    HTTP client configuration.

  sendResolved	<boolean>
    Whether to notify about resolved alerts.

  summary	<string>
    Message summary template. It requires Alertmanager >= 0.27.0.

  text	<string>
    Message body template.

  title	<string>
    Message title template.

  webhookUrl	<Object> -required-
    MSTeams webhook URL.

same as find from
https://prometheus.io/docs/alerting/0.26/configuration/#msteams_config
https://prometheus.io/docs/alerting/0.27/configuration/#msteams_config
summary field is since 0.27

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2024
@eromanova97
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label May 7, 2024
@jeana-redhat jeana-redhat added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label May 7, 2024
jeana-redhat
jeana-redhat approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels May 7, 2024
@eromanova97
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label May 9, 2024
@sheriff-rh sheriff-rh added merge-review-in-progress Signifies that the merge review team is reviewing this PR branch/enterprise-4.15 branch/enterprise-4.16 and removed merge-review-needed Signifies that the merge review team needs to review this PR labels May 9, 2024
@sheriff-rh sheriff-rh added this to the Continuous Release milestone May 9, 2024
sheriff-rh
sheriff-rh approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@sheriff-rh sheriff-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM; merging to 4.15+.

@sheriff-rh sheriff-rh merged commit 608b682 into openshift:main May 9, 2024
3 checks passed
@sheriff-rh
Copy link
Contributor

/cherrypick enterprise-4.16

@sheriff-rh
Copy link
Contributor

/cherrypick enterprise-4.15

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 9, 2024
Merged
@openshift-cherrypick-robot
Copy link

@sheriff-rh: new pull request created: #75718

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link

@sheriff-rh: new pull request created: #75719

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 9, 2024
Merged
@eromanova97 eromanova97 deleted the OBSDOCS-1009 branch May 10, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

@sheriff-rh sheriff-rh sheriff-rh approved these changes

@jeana-redhat jeana-redhat jeana-redhat approved these changes

Assignees

@juzhao juzhao

Labels
branch/enterprise-4.15 branch/enterprise-4.16 lgtm Indicates that a PR is ready to be merged. merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@eromanova97 @ocpdocs-previewbot @juzhao @sheriff-rh @openshift-cherrypick-robot @jeana-redhat @ocpdocs-vale-bot