Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OBSDOCS-1029 #75488

Merged
merged 1 commit into from
May 7, 2024
Merged

OBSDOCS-1029 #75488

merged 1 commit into from
May 7, 2024

Conversation

smunje1
Copy link
Contributor

@smunje1 smunje1 commented May 3, 2024 •
edited

OBSDOCS-1029: Incorrect indentation in "spec.collection.resources.requests" within ClusterLogging CR in "Configure log collector CPU and memory limits" doc
Aligned team: Observability
OCP version for cherry-picking: 4.12+
JIRA issues: OBSDOCS-1029
Preview pages: https://75488--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/logging/log_collection_forwarding/cluster-logging-collector#cluster-logging-collector-limits_cluster-logging-collector
SME review completed: @yuokada126
QE review completed: @QiaolingTang
Peer review completed: @xenolinux

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 3, 2024
@ocpdocs-previewbot
Copy link

🤖 Fri May 03 10:57:28 - Prow CI generated the docs preview:

https://75488--ocpdocs-pr.netlify.app/openshift-dedicated/latest/observability/logging/log_collection_forwarding/cluster-logging-collector.html
https://75488--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/logging/log_collection_forwarding/cluster-logging-collector.html
https://75488--ocpdocs-pr.netlify.app/openshift-rosa/latest/observability/logging/log_collection_forwarding/cluster-logging-collector.html

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 3, 2024

@smunje1: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@QiaolingTang
Copy link

LGTM.

@smunje1
Copy link
Contributor Author

smunje1 commented May 7, 2024

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label May 7, 2024
@xenolinux
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label May 7, 2024
xenolinux
xenolinux reviewed May 7, 2024
View reviewed changes
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Can you please specify what OCP versions are applicable for this PR?

/remove-label peer-review-needed
/remove-label peer-review-in-progress
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels May 7, 2024
@smunje1
Copy link
Contributor Author

smunje1 commented May 7, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label May 7, 2024
@skopacz1 skopacz1 added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label May 7, 2024
@skopacz1
Copy link
Contributor

skopacz1 commented May 7, 2024

Just a heads up that we're no longer making changes to 4.11 docs, 4.12 is the earliest version we're now working on

@skopacz1 skopacz1 added this to the Continuous Release milestone May 7, 2024
skopacz1
skopacz1 approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@skopacz1 skopacz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge review LGTM

@skopacz1 skopacz1 merged commit a602b22 into openshift:main May 7, 2024
3 checks passed
@skopacz1
Copy link
Contributor

skopacz1 commented May 7, 2024

/cherrypick enterprise-4.12

@skopacz1
Copy link
Contributor

skopacz1 commented May 7, 2024

/cherrypick enterprise-4.13

@skopacz1
Copy link
Contributor

skopacz1 commented May 7, 2024

/cherrypick enterprise-4.14

@skopacz1
Copy link
Contributor

skopacz1 commented May 7, 2024

/cherrypick enterprise-4.15

@skopacz1
Copy link
Contributor

skopacz1 commented May 7, 2024

/cherrypick enterprise-4.16

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 7, 2024
Merged
@openshift-cherrypick-robot
Copy link

@skopacz1: new pull request created: #75605

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@skopacz1: new pull request created: #75606

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced May 7, 2024
Merged
Merged
@openshift-cherrypick-robot
Copy link

@skopacz1: new pull request created: #75607

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 7, 2024
Merged
@openshift-cherrypick-robot
Copy link

@skopacz1: new pull request created: #75608

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@skopacz1: new pull request created: #75609

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 7, 2024
Merged
@skopacz1 skopacz1 removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xenolinux xenolinux xenolinux left review comments

@skopacz1 skopacz1 skopacz1 approved these changes

Assignees
No one assigned
Labels
branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@smunje1 @ocpdocs-previewbot @QiaolingTang @xenolinux @skopacz1 @openshift-cherrypick-robot