Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-33407 - Adding missing PTP features to TP table #75658

Merged
merged 1 commit into from
May 8, 2024
Merged

OCPBUGS-33407 - Adding missing PTP features to TP table #75658

merged 1 commit into from
May 8, 2024

Conversation

aireilly
Copy link
Contributor

@aireilly aireilly commented May 8, 2024 •
edited

Some PTP features are missing from the TP table in the release notes. These features were missed when the TP table was split into smaller tables for 4.15.

Preview:
https://75658--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-15-release-notes.html#ocp-4-15-technology-preview-tables

Version(s):
enterprise-4.15

Issue:
https://issues.redhat.com/browse/OCPBUGS-33407

Link to docs preview:

QE review:

  • QE review not required.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 8, 2024
@aireilly aireilly changed the base branch from main to enterprise-4.15 May 8, 2024 12:44
@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 8, 2024
@aireilly aireilly changed the title OCPBUGS-33407 OCPBUGS-33407 - Adding PTP features to TP table May 8, 2024
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 8, 2024
@aireilly
Copy link
Contributor Author

aireilly commented May 8, 2024

/retest

@ocpdocs-previewbot
Copy link

🤖 Wed May 08 12:53:20 - Prow CI generated the docs preview:

https://75658--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-15-release-notes.html

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 8, 2024

@aireilly: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/validate-asciidoc 9743eb7 link true /test validate-asciidoc
ci/prow/deploy-preview 9743eb7 link true /test deploy-preview
ci/prow/validate-portal 9743eb7 link true /test validate-portal

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kenyis
Copy link

kenyis commented May 8, 2024

lgtm

@aireilly aireilly changed the title OCPBUGS-33407 - Adding PTP features to TP table OCPBUGS-33407 - Adding missing PTP features to TP table May 8, 2024
@aireilly
Copy link
Contributor Author

aireilly commented May 8, 2024

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label May 8, 2024
@tmalove
Copy link
Contributor

tmalove commented May 8, 2024

/remove-label peer-review-needed
/label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels May 8, 2024
@tmalove
Copy link
Contributor

tmalove commented May 8, 2024

Hi @aireilly will you add the preview link in comment 0? Thanks!

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 8, 2024
@tmalove
Copy link
Contributor

tmalove commented May 8, 2024

/remove-label peer-review-in-progress
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels May 8, 2024
@aireilly aireilly merged commit eb5478a into openshift:enterprise-4.15 May 8, 2024
3 checks passed
aneeshkp
aneeshkp reviewed May 10, 2024
View reviewed changes
Copy link

@aneeshkp aneeshkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@aireilly
Copy link
Contributor Author

/retest

@aireilly
Copy link
Contributor Author

@adellape Any idea why this PR didn't make it into 4.15 release notes source? https://github.com/aireilly/openshift-docs/blob/enterprise-4.15/release_notes/ocp-4-15-release-notes.adoc?plain=1

It did get published though 🤷

https://docs.openshift.com/container-platform/4.15/release_notes/ocp-4-15-release-notes.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aneeshkp aneeshkp aneeshkp left review comments

Assignees
No one assigned
Labels
peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@aireilly @ocpdocs-previewbot @kenyis @tmalove @aneeshkp @openshift-merge-robot