Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OCPBUGS#33312]: Add important note when manually adding a device for IPI installation #75751

Merged
merged 1 commit into from
May 28, 2024
Merged

[OCPBUGS#33312]: Add important note when manually adding a device for IPI installation #75751

merged 1 commit into from
May 28, 2024

Conversation

tmalove
Copy link
Contributor

@tmalove tmalove commented May 9, 2024 •
edited

Version(s):
4.13+

Issue: OCPBUGS-33312

Link to docs preview:
Moving etcd to a different disk (Updated 5/20/2024)

QE review:

  • [x ] QE has approved this change.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 9, 2024
@tmalove
Copy link
Contributor Author

tmalove commented May 9, 2024 •
edited

@oarribas we should link to the manual installation steps as an additional resource. Request a review, thanks!

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented May 9, 2024 •
edited

🤖 Wed May 22 19:03:39 - Prow CI generated the docs preview:

https://75751--ocpdocs-pr.netlify.app/openshift-enterprise/latest/scalability_and_performance/recommended-performance-scale-practices/recommended-etcd-practices.html

@tmalove tmalove force-pushed the etcd-ocpbugs-33312-tlove branch 2 times, most recently from 0d87b17 to 87b217f Compare May 20, 2024 15:30
@tmalove
Copy link
Contributor Author

tmalove commented May 20, 2024

Hi @oarribas Take a look at the updated Important note. Thanks!

@oarribas
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2024
@tmalove
Copy link
Contributor Author

tmalove commented May 22, 2024

@geliu2016 Will you review this update? Thanks!

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 22, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 22, 2024

@tmalove: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@geliu2016
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 23, 2024
@tmalove
Copy link
Contributor Author

tmalove commented May 23, 2024

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label May 23, 2024
@mpandya15
Copy link
Contributor

/remove-label peer-review-needed

@mpandya15
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels May 23, 2024
JoeAldinger
JoeAldinger reviewed May 23, 2024
View reviewed changes
Copy link
Contributor

@JoeAldinger JoeAldinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only question is wether or not this needs to go through modified CM or have PX look at it because of the support statement.

@JoeAldinger JoeAldinger added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels May 23, 2024
@tmalove
Copy link
Contributor Author

tmalove commented May 28, 2024

@JoeAldinger This is a clarification of an existing status rather than a change in support status, Thank you!

@tmalove
Copy link
Contributor Author

tmalove commented May 28, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label May 28, 2024
@mburke5678 mburke5678 added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label May 28, 2024
@mburke5678 mburke5678 merged commit f99dbec into openshift:main May 28, 2024
3 checks passed
@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.13

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.14

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.15

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.16

@openshift-cherrypick-robot
Copy link

@mburke5678: new pull request created: #76573

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 28, 2024
Merged
@openshift-cherrypick-robot
Copy link

@mburke5678: new pull request created: #76574

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 28, 2024
Merged
@openshift-cherrypick-robot
Copy link

@mburke5678: new pull request created: #76575

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 28, 2024
Merged
@openshift-cherrypick-robot
Copy link

@mburke5678: new pull request created: #76576

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 28, 2024
Merged
@tmalove
Copy link
Contributor Author

tmalove commented May 28, 2024

/cherrypick enterprise-4.12

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 28, 2024
Merged
@openshift-cherrypick-robot
Copy link

@tmalove: new pull request created: #76587

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeAldinger JoeAldinger JoeAldinger left review comments

Assignees

@oarribas oarribas

@geliu2016 geliu2016

Labels
branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 lgtm Indicates that a PR is ready to be merged. merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@tmalove @ocpdocs-previewbot @oarribas @geliu2016 @mpandya15 @mburke5678 @openshift-cherrypick-robot @JoeAldinger