BZ 1247291: edits to endpoints example #914
Conversation
|
@vikram-redhat as discussed, this should probably merge so there's no more errors in the "Endpoints" sections. @tpoitras @tnguyen-rh I did some hefty editing, so this is available for peer review, if you get in in time before it's merged. |
|
|
||
| == External MySQL Database | ||
|
|
||
| One of the most common types of external services is an external database. To support an external database, an application needs: | ||
| One of the most common types of external services is an external database. To |
There was a problem hiding this comment.
Maybe remove the adjective "external" from "database"? It seems redundant.
There was a problem hiding this comment.
@tnguyen-rh I see what you mean, but I feel it's best to keep it in there, if only to differentiate between this and internal services. I know they're not available in OpenShift, but hey, they might one day.
Also, the title of the topic is "Integrating with External Services", so it might be wise to keep with the point.
Willing to haggle if you disagree 🐸
|
@tnguyen-rh thanks for the edits. Comments above, but mainly ok about it. Given the tech review thumbs up in the BZ. @vikram-redhat This might be ok to merge. I might follow up this BZ with another about creating services into your OpenShift setup. |
bfallonf
changed the title
BZ 1247291: edits to endpoints example
Edits to the endpoints example as per BZ:
https://bugzilla.redhat.com/show_bug.cgi?id=1247291
This sort of (improves on) the work from #905
It was made more obvious that the endpoints example still does not work. It needed the "name" value in the example. It's now been added.
I've also performed some general editing in the section.