[peer review] BZ 1259700 fix command to aggregate logs #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Comment from @miheer in the BZ: "It seems to be good. Thanks!" This should be ready to be put onto peer review. |
bfallonf
changed the title
vikram-redhat
added a commit
that referenced
this pull request
Sep 15, 2015
BZ 1259700 fix command to aggregate logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@miheer this is concerning the following BZ:
https://bugzilla.redhat.com/show_bug.cgi?id=1259700
I added the commands as requested, but I'm not sure if "housing the logs" is what the directory is doing, exactly. Can I ask for a quick tech review?
Thanks!