Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console 2384: Adding Workloads metrics charts #501

Merged
merged 4 commits into from Jan 22, 2021

Conversation

andrew-ronaldson
Copy link
Contributor

@andrew-ronaldson andrew-ronaldson commented Jan 6, 2021

This is work on the story Console-2384. The goal is to add charts back into the following Workloads pages ; Deployments, Deployment Configs, StatefulSets, DaemonSets, ReplicaSets, and ReplicationControllers.

I am proposing that we roll this out in two stages.

  1. Adding multi-line charts in the same page layout as the 4.6 Pods page. Legends on these charts could be added for legibility of data.
  2. Moving these charts into a Metrics tab which will give more space for larger charts with legends, tooltips and reporting through Prometheus

Design story: https://issues.redhat.com/browse/PD-662
Console story: https://issues.redhat.com/browse/CONSOLE-2384

@openshift/team-ux-leads

@openshift/team-ux-review (Administrator perspective)

@smarterclayton @alimobrem

This is work on jira issue Console-2384. The goal is to add charts back into the following Workloads pages ; Deployments, Deployment Configs, StatefulSets, DaemonSets, ReplicaSets, and ReplicationControllers
Copy link
Member

@beanh66 beanh66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

Only thing to note is we might want to pull out the future enhancement part and put in a 4.x section to be sure we don't forget about it and Ali has a place to reference that forward looking design. I don't think we have a Console story for it yet so we might lose track. Thoughts @andrew-ronaldson?

@andrew-ronaldson
Copy link
Contributor Author

Thanks @beanh66 for reviewing.
I agree with you on the future enhancements section and will make the change. There is definitely more conversation needed to understand the best solution and syncing with other areas of the console. Thanks!

Copy link
Contributor

@cshinn cshinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I guess we need a bit more discussion about when it makes sense to include chart legends, but both of these options look good

@andrew-ronaldson
Copy link
Contributor Author

@cshinn I feel like the legends could be left off until we can move to larger chart view (in separate tab). Might be too difficult to read as the legend items will be truncated to fit the space.

@cshinn
Copy link
Contributor

cshinn commented Jan 7, 2021

@andrew-ronaldson I totally agree. Especially if we include the new stacked tooltips, I don't think legends would be required/useful here

Copy link
Contributor

@gdoyle1 gdoyle1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!! Looks great

Copy link
Contributor

@itsptk itsptk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice first PR! LGTM 👍

@beanh66 beanh66 merged commit 9faf56a into openshift:master Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants