New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Console 2384: Adding Workloads metrics charts #501
Conversation
This is work on jira issue Console-2384. The goal is to add charts back into the following Workloads pages ; Deployments, Deployment Configs, StatefulSets, DaemonSets, ReplicaSets, and ReplicationControllers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me!
Only thing to note is we might want to pull out the future enhancement part and put in a 4.x section to be sure we don't forget about it and Ali has a place to reference that forward looking design. I don't think we have a Console story for it yet so we might lose track. Thoughts @andrew-ronaldson?
Thanks @beanh66 for reviewing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! I guess we need a bit more discussion about when it makes sense to include chart legends, but both of these options look good
@cshinn I feel like the legends could be left off until we can move to larger chart view (in separate tab). Might be too difficult to read as the legend items will be truncated to fit the space. |
@andrew-ronaldson I totally agree. Especially if we include the new stacked tooltips, I don't think legends would be required/useful here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!! Looks great
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice first PR! LGTM 👍
This is work on the story Console-2384. The goal is to add charts back into the following Workloads pages ; Deployments, Deployment Configs, StatefulSets, DaemonSets, ReplicaSets, and ReplicationControllers.
I am proposing that we roll this out in two stages.
Design story: https://issues.redhat.com/browse/PD-662
Console story: https://issues.redhat.com/browse/CONSOLE-2384
@openshift/team-ux-leads
@openshift/team-ux-review (Administrator perspective)
@smarterclayton @alimobrem