Fixing HPA not converting apiGroup for deploymentconfigs #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ammachado Thank you for the fix. |
pranavgaikwad
requested changes
Apr 14, 2022
sseago
reviewed
Apr 14, 2022
velero-plugins/common/restore.go
Outdated
| @@ -41,7 +41,8 @@ func (p *RestorePlugin) AppliesTo() (velero.ResourceSelector, error) { | |||
| "replicasets.extensions", | |||
| "replicationcontroller", | |||
| "buildconfigs", | |||
| "buildconfigs.build.openshift.io"}, | |||
| "buildconfigs.build.openshift.io", | |||
| "horizontalpodautoscalers"}, | |||
There was a problem hiding this comment.
Why is this needed? I don't see anything in the below horizontalpodautoscaler restore plugin that relies on the actions of the common restore plugin here.
There was a problem hiding this comment.
I am not sure if it is needed, but on this list is all of the plugins that are present in the application.
There was a problem hiding this comment.
@ammachado This can be removed from the common plugin since we have a separate plugin registered for hpa
There was a problem hiding this comment.
@ammachado This list the resources that specifically need the actions taken in this plugin. Originally we applied these actions to all resources, but that resulted in poor performance when there were large numbers of resources being backed up and restored that didn't benefit from the actions of this plugin. Unless there's something this plugin does that your plugin relies on (and I don't think that's the case), then this is unnecessary.
Co-authored-by: Pranav Gaikwad <pgaikwad@redhat.com>
Co-authored-by: Pranav Gaikwad <pgaikwad@redhat.com>
sseago
approved these changes
Apr 18, 2022
pranavgaikwad
approved these changes
Apr 18, 2022
velero-plugins/common/restore.go
Outdated
| @@ -41,7 +41,8 @@ func (p *RestorePlugin) AppliesTo() (velero.ResourceSelector, error) { | |||
| "replicasets.extensions", | |||
| "replicationcontroller", | |||
| "buildconfigs", | |||
| "buildconfigs.build.openshift.io"}, | |||
| "buildconfigs.build.openshift.io", | |||
| "horizontalpodautoscalers"}, | |||
There was a problem hiding this comment.
@ammachado This can be removed from the common plugin since we have a separate plugin registered for hpa
rayfordj
pushed a commit
to rayfordj/openshift-velero-plugin
that referenced
this pull request
Apr 20, 2022
* Fixing HPA not converting apiGroup for deploymentconfigs * Fixing typos * Update velero-plugins/horizontalpodautoscaler/restore.go Co-authored-by: Pranav Gaikwad <pgaikwad@redhat.com> * Update velero-plugins/horizontalpodautoscaler/restore.go Co-authored-by: Pranav Gaikwad <pgaikwad@redhat.com> * Throwing error when it's not possible to parse APIVersion of hpa.spec.scaleTargetRef * Excluding HPA from common restore plugin Co-authored-by: Adriano Marcondes Machado <admachad@redhat.com> Co-authored-by: Pranav Gaikwad <pgaikwad@redhat.com>
rayfordj
pushed a commit
to rayfordj/openshift-velero-plugin
that referenced
this pull request
Apr 20, 2022
* Fixing HPA not converting apiGroup for deploymentconfigs * Fixing typos * Update velero-plugins/horizontalpodautoscaler/restore.go Co-authored-by: Pranav Gaikwad <pgaikwad@redhat.com> * Update velero-plugins/horizontalpodautoscaler/restore.go Co-authored-by: Pranav Gaikwad <pgaikwad@redhat.com> * Throwing error when it's not possible to parse APIVersion of hpa.spec.scaleTargetRef * Excluding HPA from common restore plugin Co-authored-by: Adriano Marcondes Machado <admachad@redhat.com> Co-authored-by: Pranav Gaikwad <pgaikwad@redhat.com>
rayfordj
added a commit
that referenced
this pull request
Apr 20, 2022
* Fixing HPA not converting apiGroup for deploymentconfigs * Fixing typos * Update velero-plugins/horizontalpodautoscaler/restore.go Co-authored-by: Pranav Gaikwad <pgaikwad@redhat.com> * Update velero-plugins/horizontalpodautoscaler/restore.go Co-authored-by: Pranav Gaikwad <pgaikwad@redhat.com> * Throwing error when it's not possible to parse APIVersion of hpa.spec.scaleTargetRef * Excluding HPA from common restore plugin Co-authored-by: Adriano Marcondes Machado <admachad@redhat.com> Co-authored-by: Pranav Gaikwad <pgaikwad@redhat.com> Co-authored-by: Adriano Machado <60320+ammachado@users.noreply.github.com> Co-authored-by: Adriano Marcondes Machado <admachad@redhat.com> Co-authored-by: Pranav Gaikwad <pgaikwad@redhat.com>
rayfordj
added a commit
that referenced
this pull request
Apr 21, 2022
* Fixing HPA not converting apiGroup for deploymentconfigs * Fixing typos * Update velero-plugins/horizontalpodautoscaler/restore.go Co-authored-by: Pranav Gaikwad <pgaikwad@redhat.com> * Update velero-plugins/horizontalpodautoscaler/restore.go Co-authored-by: Pranav Gaikwad <pgaikwad@redhat.com> * Throwing error when it's not possible to parse APIVersion of hpa.spec.scaleTargetRef * Excluding HPA from common restore plugin Co-authored-by: Adriano Marcondes Machado <admachad@redhat.com> Co-authored-by: Pranav Gaikwad <pgaikwad@redhat.com> Co-authored-by: Adriano Machado <60320+ammachado@users.noreply.github.com> Co-authored-by: Adriano Marcondes Machado <admachad@redhat.com> Co-authored-by: Pranav Gaikwad <pgaikwad@redhat.com>
sseago
pushed a commit
to sseago/openshift-velero-plugin
that referenced
this pull request
May 3, 2022
* Fixing HPA not converting apiGroup for deploymentconfigs * Fixing typos * Update velero-plugins/horizontalpodautoscaler/restore.go Co-authored-by: Pranav Gaikwad <pgaikwad@redhat.com> * Update velero-plugins/horizontalpodautoscaler/restore.go Co-authored-by: Pranav Gaikwad <pgaikwad@redhat.com> * Throwing error when it's not possible to parse APIVersion of hpa.spec.scaleTargetRef * Excluding HPA from common restore plugin Co-authored-by: Adriano Marcondes Machado <admachad@redhat.com> Co-authored-by: Pranav Gaikwad <pgaikwad@redhat.com>
dymurray
pushed a commit
that referenced
this pull request
May 9, 2022
* Fixing HPA not converting apiGroup for deploymentconfigs (#126) * Fixing HPA not converting apiGroup for deploymentconfigs * Fixing typos * Update velero-plugins/horizontalpodautoscaler/restore.go Co-authored-by: Pranav Gaikwad <pgaikwad@redhat.com> * Update velero-plugins/horizontalpodautoscaler/restore.go Co-authored-by: Pranav Gaikwad <pgaikwad@redhat.com> * Throwing error when it's not possible to parse APIVersion of hpa.spec.scaleTargetRef * Excluding HPA from common restore plugin Co-authored-by: Adriano Marcondes Machado <admachad@redhat.com> Co-authored-by: Pranav Gaikwad <pgaikwad@redhat.com> * run `go mod tidy` Co-authored-by: Adriano Machado <60320+ammachado@users.noreply.github.com> Co-authored-by: Adriano Marcondes Machado <admachad@redhat.com> Co-authored-by: Pranav Gaikwad <pgaikwad@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ApiGroup for HPA ScaleTargetRef when it is a deploymentconfig is not changed to the new version.