Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2072311: Fixing HPA not converting apiGroup for deploymentconfigs (#126) #131

Merged
merged 1 commit into from
Apr 20, 2022
Merged

Bug 2072311: Fixing HPA not converting apiGroup for deploymentconfigs (#126) #131

merged 1 commit into from
Apr 20, 2022

Conversation

rayfordj
Copy link
Contributor

  • Fixing HPA not converting apiGroup for deploymentconfigs

  • Fixing typos

  • Update velero-plugins/horizontalpodautoscaler/restore.go

Co-authored-by: Pranav Gaikwad pgaikwad@redhat.com

  • Update velero-plugins/horizontalpodautoscaler/restore.go

Co-authored-by: Pranav Gaikwad pgaikwad@redhat.com

  • Throwing error when it's not possible to parse APIVersion of hpa.spec.scaleTargetRef

  • Excluding HPA from common restore plugin

Co-authored-by: Adriano Marcondes Machado admachad@redhat.com
Co-authored-by: Pranav Gaikwad pgaikwad@redhat.com

@ammachado @pranavgaikwad @rayfordj
Fixing HPA not converting apiGroup for deploymentconfigs (openshift#126)
1f9a526 
* Fixing HPA not converting apiGroup for deploymentconfigs

* Fixing typos

* Update velero-plugins/horizontalpodautoscaler/restore.go

Co-authored-by: Pranav Gaikwad <pgaikwad@redhat.com>

* Update velero-plugins/horizontalpodautoscaler/restore.go

Co-authored-by: Pranav Gaikwad <pgaikwad@redhat.com>

* Throwing error when it's not possible to parse APIVersion of hpa.spec.scaleTargetRef

* Excluding HPA from common restore plugin

Co-authored-by: Adriano Marcondes Machado <admachad@redhat.com>
Co-authored-by: Pranav Gaikwad <pgaikwad@redhat.com>
@rayfordj rayfordj self-assigned this Apr 20, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 20, 2022
@openshift-ci
Copy link

openshift-ci bot commented Apr 20, 2022

@rayfordj: This pull request references Bugzilla bug 2072311, which is invalid:

  • expected Bugzilla bug 2072311 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2072311: Fixing HPA not converting apiGroup for deploymentconfigs (#126)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rayfordj rayfordj merged commit 94a0fe0 into openshift:release-1.6.5 Apr 20, 2022
@openshift-ci
Copy link

openshift-ci bot commented Apr 20, 2022

@rayfordj: All pull requests linked via external trackers have merged:

Bugzilla bug 2072311 has been moved to the MODIFIED state.

In response to this:

Bug 2072311: Fixing HPA not converting apiGroup for deploymentconfigs (#126)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rayfordj rayfordj deleted the bz2072311 branch April 20, 2022 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sseago sseago sseago approved these changes

@pranavgaikwad pranavgaikwad Awaiting requested review from pranavgaikwad

Assignees

@rayfordj rayfordj

Labels
bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rayfordj @sseago @ammachado