OADP-205 Fetch and decode secret for registry plugin environment #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaovilai
force-pushed
the
upstream-master-registry-secret-fetch
branch
2 times, most recently
from
dd3084a
to
c3f4d94
Compare
kaovilai
changed the title
kaovilai
changed the title
kaovilai
force-pushed
the
upstream-master-registry-secret-fetch
branch
from
c3f4d94
to
14f229e
Compare
shubham-pampattiwar
approved these changes
Jul 11, 2022
|
local build succeeded skipping PR travis. Will wait for master travis. |
kaovilai
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fetches secret and decode them for use in Registry "environment variables" parameters for initializing plugin registry.
Previous to this, registry environment variables returned from provider functions were wrongly assumed to be set in envVar.Value exclusively. This PR add support for envVar.ValueFrom.SecretKeyRef.
OADP-205