Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OADP-1057 add support for aws sts creds for registry #198

Closed
wants to merge 1 commit into from

Conversation

kaovilai
Copy link
Member

@kaovilai kaovilai commented Jul 10, 2023

Todo:

  • read secret from bsl spec.

Highlights

github.com/kaovilai/udistribution v0.0.10-oadp-1.2

// openshift/docker-distribution release-4.14 branch which contain following unmerged distribution/distribution PRs:
// - aws shared config support (sts assume role)
replace github.com/distribution/distribution/v3 => github.com/openshift/docker-distribution/v3 v3.0.0-20230626115833-c7be7b49aed9

Signed-off-by: Tiger Kaovilai tkaovila@redhat.com

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 10, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jul 10, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link

openshift-ci bot commented Jul 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2023
@kaovilai kaovilai changed the title add support for aws sts creds for registry OADP-1057 add support for aws sts creds for registry Jul 10, 2023
@kaovilai kaovilai closed this Jul 12, 2023
@kaovilai kaovilai deleted the aws-sts-registry branch July 12, 2023 00:28
@kaovilai
Copy link
Member Author

replaced by #199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant