OADP-1057: AWS STS Creds support for internal image backup #199

kaovilai · 2023-07-12T00:25:00Z

add support for aws sts creds for registry
remove image-spec replace breaking build, previously there for CVE.. now the dep is much newer..
OADP-1057: STS creds support for internal image backup
remove kopia dependency by removing podvolume package also available as a separate PR. Remove non-working code for backing up completed build pods #200 but it is required here to build.. so can rebase after that merged or vice versa.

⏯️ Testing instructions 🏈

TODO:

remove replace github.com/vmware-tanzu/velero v1.11.0 => github.com/kaovilai/velero v0000- // TODO: remove when https://github.com/openshift/velero/pull/279 is merged oadp-1.2: Moving kopia logging to remove kopia from indirect dependency in vele… velero#279
Update secret handling to support new field

test image

ghcr.io/kaovilai/openshift-velero-plugin:sts

dpa

apiVersion: oadp.openshift.io/v1alpha1
kind: DataProtectionApplication
metadata:
  name: dpa-sample
spec:
  unsupportedOverrides:
    openshiftPluginImageFqin: ghcr.io/kaovilai/openshift-velero-plugin:sts

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

openshift-ci · 2023-07-12T00:25:05Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

No longer needed after by vmware-tanzu/velero#6189 or vmware-tanzu/velero#6188 which fix vmware-tanzu/velero#6182 Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> remove pod backup plugin from main.go

… UID when copying Resolves ``` > [builder 6/6] RUN go build -installsuffix "static" -tags "containers_image_ostree_stub exclude_graphdriver_devicemapper exclude_graphdriver_btrfs containers_image_openpgp exclude_graphdriver_overlay include_gcs include_oss" -o _output/velero-plugins ./velero-plugins: #0 4.584 error obtaining VCS status: exit status 128 #0 4.584 Use -buildvcs=false to disable VCS stamping. ``` Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

go.mod

kaovilai · 2023-07-21T06:06:24Z

/test all

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

kaovilai · 2023-07-24T18:44:39Z

Did some sanity testing. The changes work as intended. Marking ready for review.

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

openshift-ci-robot · 2023-07-24T18:49:57Z

@kaovilai: This pull request references OADP-1057 which is a valid jira issue.

In response to this:

add support for aws sts creds for registry

remove image-spec replace breaking build, previously there for CVE.. now the dep is much newer..

OADP-1057: STS creds support for internal image backup

remove kopia dependency by removing podvolume package also available as a separate PR. Remove non-working code for backing up completed build pods #200 but it is required here to build.. so can rebase after that merged or vice versa.

TODO:

remove replace github.com/vmware-tanzu/velero v1.11.0 => github.com/kaovilai/velero v0000- // TODO: remove when https://github.com/openshift/velero/pull/279 is merged

Update secret handling to support new field

test image
ghcr.io/kaovilai/openshift-velero-plugin:sts
dpa
apiVersion: oadp.openshift.io/v1alpha1
kind: DataProtectionApplication
metadata:
 name: dpa-sample
spec:
 unsupportedOverrides:
   openshiftPluginImageFqin: ghcr.io/kaovilai/openshift-velero-plugin:sts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

weshayutin · 2023-07-24T18:50:53Z

w/ backupImages: true
w/ patch:

https://termbin.com/0h91

[whayutin@thinkdoe ROSA]$ velero backup get hello-world-patch2 
NAME                 STATUS      ERRORS   WARNINGS   CREATED                         EXPIRES   STORAGE LOCATION     SELECTOR
hello-world-patch2   Completed   0        0          2023-07-24 18:38:14 +0000 UTC   29d       wdh07052023d-dpa-1   <none>
[whayutin@thinkdoe ROSA]$ oc get dpa -o yaml | grep -i image
    backupImages: true
      openshiftPluginImageFqin: ghcr.io/kaovilai/openshift-velero-plugin:sts

kaovilai · 2023-07-24T19:06:01Z

/hold for 1.2.2

openshift-ci-robot · 2023-08-11T18:11:32Z

@kaovilai: This pull request references OADP-1057 which is a valid jira issue.

In response to this:

add support for aws sts creds for registry

remove image-spec replace breaking build, previously there for CVE.. now the dep is much newer..

OADP-1057: STS creds support for internal image backup

remove kopia dependency by removing podvolume package also available as a separate PR. Remove non-working code for backing up completed build pods #200 but it is required here to build.. so can rebase after that merged or vice versa.

Testing instructions

TODO:

remove replace github.com/vmware-tanzu/velero v1.11.0 => github.com/kaovilai/velero v0000- // TODO: remove when https://github.com/openshift/velero/pull/279 is merged

Update secret handling to support new field

test image
ghcr.io/kaovilai/openshift-velero-plugin:sts
dpa
apiVersion: oadp.openshift.io/v1alpha1
kind: DataProtectionApplication
metadata:
 name: dpa-sample
spec:
 unsupportedOverrides:
   openshiftPluginImageFqin: ghcr.io/kaovilai/openshift-velero-plugin:sts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-08-11T18:12:03Z

@kaovilai: This pull request references OADP-1057 which is a valid jira issue.

In response to this:

add support for aws sts creds for registry

remove image-spec replace breaking build, previously there for CVE.. now the dep is much newer..

OADP-1057: STS creds support for internal image backup

remove kopia dependency by removing podvolume package also available as a separate PR. Remove non-working code for backing up completed build pods #200 but it is required here to build.. so can rebase after that merged or vice versa.

⏯️ Testing instructions 🏈

TODO:

remove replace github.com/vmware-tanzu/velero v1.11.0 => github.com/kaovilai/velero v0000- // TODO: remove when https://github.com/openshift/velero/pull/279 is merged

Update secret handling to support new field

test image
ghcr.io/kaovilai/openshift-velero-plugin:sts
dpa
apiVersion: oadp.openshift.io/v1alpha1
kind: DataProtectionApplication
metadata:
 name: dpa-sample
spec:
 unsupportedOverrides:
   openshiftPluginImageFqin: ghcr.io/kaovilai/openshift-velero-plugin:sts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-08-11T18:12:42Z

@kaovilai: This pull request references OADP-1057 which is a valid jira issue.

In response to this:

add support for aws sts creds for registry

remove image-spec replace breaking build, previously there for CVE.. now the dep is much newer..

OADP-1057: STS creds support for internal image backup

remove kopia dependency by removing podvolume package also available as a separate PR. Remove non-working code for backing up completed build pods #200 but it is required here to build.. so can rebase after that merged or vice versa.

⏯️ Testing instructions 🏈

TODO:

remove replace github.com/vmware-tanzu/velero v1.11.0 => github.com/kaovilai/velero v0000- // TODO: remove when https://github.com/openshift/velero/pull/279 is merged oadp-1.2: Moving kopia logging to remove kopia from indirect dependency in vele… velero#279

Update secret handling to support new field

test image
ghcr.io/kaovilai/openshift-velero-plugin:sts
dpa
apiVersion: oadp.openshift.io/v1alpha1
kind: DataProtectionApplication
metadata:
 name: dpa-sample
spec:
 unsupportedOverrides:
   openshiftPluginImageFqin: ghcr.io/kaovilai/openshift-velero-plugin:sts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-08-21T19:55:37Z

@kaovilai: This pull request references OADP-1057 which is a valid jira issue.

In response to this:

add support for aws sts creds for registry

remove image-spec replace breaking build, previously there for CVE.. now the dep is much newer..

OADP-1057: STS creds support for internal image backup

remove kopia dependency by removing podvolume package also available as a separate PR. Remove non-working code for backing up completed build pods #200 but it is required here to build.. so can rebase after that merged or vice versa.

⏯️ Testing instructions 🏈

TODO:

remove replace github.com/vmware-tanzu/velero v1.11.0 => github.com/kaovilai/velero v0000- // TODO: remove when https://github.com/openshift/velero/pull/279 is merged oadp-1.2: Moving kopia logging to remove kopia from indirect dependency in vele… velero#279

Update secret handling to support new field

test image
ghcr.io/kaovilai/openshift-velero-plugin:sts
dpa
apiVersion: oadp.openshift.io/v1alpha1
kind: DataProtectionApplication
metadata:
 name: dpa-sample
spec:
 unsupportedOverrides:
   openshiftPluginImageFqin: ghcr.io/kaovilai/openshift-velero-plugin:sts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kaovilai · 2023-08-21T19:55:52Z

/unhold

kaovilai · 2023-08-21T19:56:20Z

/cherry-pick oadp-1.2

openshift-cherrypick-robot · 2023-08-21T19:56:22Z

@kaovilai: once the present PR merges, I will cherry-pick it on top of oadp-1.2 in a new PR and assign it to you.

In response to this:

/cherry-pick oadp-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-08-21T19:59:42Z

@kaovilai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

sseago · 2023-08-22T17:16:48Z

/lgtm

openshift-ci · 2023-08-22T17:17:11Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, sseago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [kaovilai,sseago]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-cherrypick-robot · 2023-08-22T17:22:32Z

@kaovilai: new pull request created: #202

In response to this:

/cherry-pick oadp-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kaovilai added 2 commits July 10, 2023 12:48

add support for aws sts creds for registry

1bbb24f

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

remove image-spec replace breaking build

a2e9c99

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 12, 2023

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2023

OADP-1057: STS creds support for internal image backup

a716260

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

kaovilai force-pushed the aws-sts-registry branch from 9cbdde9 to a716260 Compare July 12, 2023 00:35

kaovilai added 2 commits July 11, 2023 21:16

Remove non-working code for backing up completed build pods

f048be7

No longer needed after by vmware-tanzu/velero#6189 or vmware-tanzu/velero#6188 which fix vmware-tanzu/velero#6182 Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> remove pod backup plugin from main.go

kaovilai force-pushed the aws-sts-registry branch from 0020d52 to 9fa8987 Compare July 12, 2023 01:17

kaovilai commented Jul 12, 2023

View reviewed changes

go.mod Outdated Show resolved Hide resolved

update go.mod to openshift/velero #276

2b45ce5

kaovilai force-pushed the aws-sts-registry branch 2 times, most recently from ab0d402 to cf88caf Compare July 21, 2023 05:31

add sts cred secret handling

adf11bd

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

kaovilai force-pushed the aws-sts-registry branch from cf88caf to adf11bd Compare July 21, 2023 06:25

kaovilai marked this pull request as ready for review July 24, 2023 18:44

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 24, 2023

openshift-ci bot requested review from shubham-pampattiwar and sseago July 24, 2023 18:46

Pass secret path instead of web_identity_token_file

5fa6472

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

kaovilai force-pushed the aws-sts-registry branch from 52739c6 to 5fa6472 Compare July 24, 2023 18:49

kaovilai changed the title ~~AWS STS Creds support for internal image backup~~ OADP-1057: AWS STS Creds support for internal image backup Jul 24, 2023

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 24, 2023

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2023

kaovilai mentioned this pull request Jul 26, 2023

OADP-1057 add support for aws sts creds for registry #198

Closed

1 task

kaovilai mentioned this pull request Aug 11, 2023

OADP-1057: CloudStorageLocation Prefix/CACert support openshift/oadp-operator#1126

Merged

Update go.mod to openshift/oadp-1.2

f03ddb6

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 21, 2023

sseago approved these changes Aug 22, 2023

View reviewed changes

openshift-ci bot assigned sseago Aug 22, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2023

openshift-merge-robot merged commit 38fd1f4 into openshift:master Aug 22, 2023
3 checks passed

openshift-cherrypick-robot mentioned this pull request Aug 22, 2023

[oadp-1.2] OADP-1057: AWS STS Creds support for internal image backup #202

Merged

This was referenced Oct 10, 2023

WIF imagestream backup support in openshift-velero-plugin openshift/oadp-operator#1175

Closed

Remove non-working code for backing up completed build pods #200

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OADP-1057: AWS STS Creds support for internal image backup #199

OADP-1057: AWS STS Creds support for internal image backup #199

kaovilai commented Jul 12, 2023 •

edited

openshift-ci bot commented Jul 12, 2023

kaovilai commented Jul 21, 2023

kaovilai commented Jul 24, 2023

openshift-ci-robot commented Jul 24, 2023 •

edited by openshift-ci bot

weshayutin commented Jul 24, 2023

kaovilai commented Jul 24, 2023

openshift-ci-robot commented Aug 11, 2023 •

edited by openshift-ci bot

Testing instructions

openshift-ci-robot commented Aug 11, 2023 •

edited by openshift-ci bot

⏯️ Testing instructions 🏈

openshift-ci-robot commented Aug 11, 2023 •

edited by openshift-ci bot

⏯️ Testing instructions 🏈

openshift-ci-robot commented Aug 21, 2023 •

edited by openshift-ci bot

⏯️ Testing instructions 🏈

kaovilai commented Aug 21, 2023

kaovilai commented Aug 21, 2023

openshift-cherrypick-robot commented Aug 21, 2023

openshift-ci bot commented Aug 21, 2023

sseago commented Aug 22, 2023

openshift-ci bot commented Aug 22, 2023

openshift-cherrypick-robot commented Aug 22, 2023

OADP-1057: AWS STS Creds support for internal image backup #199

OADP-1057: AWS STS Creds support for internal image backup #199

Conversation

kaovilai commented Jul 12, 2023 • edited

⏯️ Testing instructions 🏈

openshift-ci bot commented Jul 12, 2023

kaovilai commented Jul 21, 2023

kaovilai commented Jul 24, 2023

openshift-ci-robot commented Jul 24, 2023 • edited by openshift-ci bot

weshayutin commented Jul 24, 2023

kaovilai commented Jul 24, 2023

openshift-ci-robot commented Aug 11, 2023 • edited by openshift-ci bot

Testing instructions

openshift-ci-robot commented Aug 11, 2023 • edited by openshift-ci bot

⏯️ Testing instructions 🏈

openshift-ci-robot commented Aug 11, 2023 • edited by openshift-ci bot

⏯️ Testing instructions 🏈

openshift-ci-robot commented Aug 21, 2023 • edited by openshift-ci bot

⏯️ Testing instructions 🏈

kaovilai commented Aug 21, 2023

kaovilai commented Aug 21, 2023

openshift-cherrypick-robot commented Aug 21, 2023

openshift-ci bot commented Aug 21, 2023

sseago commented Aug 22, 2023

openshift-ci bot commented Aug 22, 2023

openshift-cherrypick-robot commented Aug 22, 2023

kaovilai commented Jul 12, 2023 •

edited

openshift-ci-robot commented Jul 24, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Aug 11, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Aug 11, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Aug 11, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Aug 21, 2023 •

edited by openshift-ci bot