-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-34870: Correct out-of-bounds check #170
Conversation
Ensure that we have the same number or fewer compute AZs than volume AZs. Also better handle mismatches between the two . Signed-off-by: Stephen Finucane <stephenfin@redhat.com> Suggested-by: Daniel Kobras
@stephenfin: This pull request references Jira Issue OCPBUGS-34870, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@stephenfin: This pull request references Jira Issue OCPBUGS-34870, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (itbrown@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/label acknowledge-critical-fixes-only |
@mandre: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mandre, stephenfin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@stephenfin: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@stephenfin: Jira Issue OCPBUGS-34870: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-34870 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@mandre: new pull request created: #171 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-openstack-cinder-csi-driver-operator-container-v4.17.0-202406050012.p0.g81e16ff.assembly.stream.el9 for distgit ose-openstack-cinder-csi-driver-operator. |
/cherry-pick release-4.15 release-4.14 |
@stephenfin: new pull request created: #172 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Ensure that we have the same number or fewer compute AZs than volume AZs. Also better handle mismatches between the two.
Signed-off-by: Stephen Finucane stephenfin@redhat.com
Suggested-by: Daniel Kobras (@dkobras)