Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.12] OCPBUGS-12993: vmedia insert #17

Merged
merged 3 commits into from
May 3, 2023
Merged

[release-4.12] OCPBUGS-12993: vmedia insert #17

merged 3 commits into from
May 3, 2023

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #15

/assign derekhiggins

derekhiggins and others added 2 commits May 2, 2023 08:51
@derekhiggins
Add TransferProtocolType for any general error that mentions it
cb70225 
Story: 2010621
Task: 47554
Change-Id: I0d1a200c3fe3d4806d660553ee2f59b8d217f06c
@iurygregory
Handle TransferMethod in vmedia insertion
c1ac345 
This commit adds the TransferMethod to insertmedia
calls if necessary.

Some HW require that the TransferMethod is set before
inserting virtual media.

Change-Id: I7fc5d41cdcf79d61cb1906f2755f55f284efe766
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 2, 2023
Merged
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-12698 has been cloned as Jira Issue OCPBUGS-12993. Will retitle bug to link to clone.
/retitle [release-4.12] OCPBUGS-12993: vmedia insert

In response to this:

This is an automated cherry-pick of #15

/assign derekhiggins

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.12] OCPBUGS-12698: vmedia insert [release-4.12] OCPBUGS-12993: vmedia insert May 2, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 2, 2023

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.12] OCPBUGS-12993: vmedia insert

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 2, 2023
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-12993, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-12698 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-12698 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0
  • bug has dependents

Requesting review from QA contact:
/cc @pamoedom

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #15

/assign derekhiggins

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from pamoedom May 2, 2023 08:51
@derekhiggins
Copy link

/test unit

@derekhiggins
Remove skipsdist from tox.ini
a941e38 
We need tox create a source distribution before running
tests (so stevedore can find all vendor extensions)

Change-Id: I48759b9529d78409be45ec52bdefea9b541ab482
@elfosardo
Copy link

/approve

@openshift-ci-robot openshift-ci-robot mentioned this pull request May 3, 2023
Merged
@derekhiggins
Copy link

/approve
want to see if it re-triggers the /approve above

@openshift-ci
Copy link

openshift-ci bot commented May 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekhiggins, elfosardo, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [derekhiggins,elfosardo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2023
@derekhiggins
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 3, 2023

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 7ea419f into openshift:release-4.12 May 3, 2023
4 checks passed
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-12993: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-12993 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #15

/assign derekhiggins

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@derekhiggins
Copy link

/cherry-pick release-4.11

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 11, 2023
Merged
@openshift-cherrypick-robot
Copy link
Author

@derekhiggins: new pull request created: #29

In response to this:

/cherry-pick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pamoedom pamoedom Awaiting requested review from pamoedom

Assignees

@derekhiggins derekhiggins

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@openshift-cherrypick-robot @openshift-ci-robot @derekhiggins @elfosardo @openshift-merge-robot @iurygregory