Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG 1984538: Remove monitoring label from openshift-operators namespace #130

Merged
merged 1 commit into from
Jul 27, 2021
Merged

BUG 1984538: Remove monitoring label from openshift-operators namespace #130

merged 1 commit into from
Jul 27, 2021

Conversation

awgreene
Copy link
Contributor

This commit updates the generate_crd_manifests.sh script
so it does not enable cluster monitoring on the openshift-operators
namespace.

@awgreene
Remove monitoring label from openshift-operators namespace
5e7648a 
This commit updates the generate_crd_manifests.sh script
so it does not enable cluster monitoring on the openshift-operators
namespace.
@openshift-ci openshift-ci bot requested review from benluddy and hasbro17 July 22, 2021 14:33
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 22, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 22, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 22, 2021

@awgreene: This pull request references Bugzilla bug 1984538, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

In response to this:

BUG 1984538: Remove monitoring label from openshift-operators namespace

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from jianzhangbjz July 22, 2021 14:33
@timflannagan
Copy link
Contributor

We may want to get another downstream port before landing anything out of band.

/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 22, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2021
@timflannagan
Copy link
Contributor

/retest
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 26, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 3475b1d into openshift:master Jul 27, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 27, 2021

@awgreene: All pull requests linked via external trackers have merged:

Bugzilla bug 1984538 has been moved to the MODIFIED state.

In response to this:

BUG 1984538: Remove monitoring label from openshift-operators namespace

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

anik120 pushed a commit to anik120/operator-framework-olm that referenced this pull request Dec 9, 2021
@varshaprasad96 @timflannagan
chore: bump k8s to 1.21 (openshift#130)
03b6e7e 
This commit bemps controller runtime to 0.9.0 and other
k8s dependencies to 1.21.

Upstream-repository: api
Upstream-commit: 392ae3918731dbd1f8732823048b2b3ec56401b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benluddy benluddy Awaiting requested review from benluddy

@hasbro17 hasbro17 Awaiting requested review from hasbro17

@jianzhangbjz jianzhangbjz Awaiting requested review from jianzhangbjz

Assignees

@timflannagan timflannagan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@awgreene @timflannagan @openshift-bot @openshift-merge-robot