Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1982737: Make malformed CSV fail nicely (#2673) #307

Merged
merged 1 commit into from May 18, 2022

Commits on May 13, 2022

  1. FIX: Bug 1982737 - Make malformed CSV fail nicely (#2673)

    - Modified bundle unpacking to fail installPlan with a nice message if
    after unbundling csv manifests APIVersion or Kind are blank.
    
    - Adds FatalError type to return to checked when syncing install plans
     to see if the error causing issues is fatal or should cause the
     IP to be transitioned to failed state.
    
    - Makes installPlan fail with a nicer more user friendly message than
    the current difficult to understand message regarding serviceAccounts.
    
    - Adds tests using internal magic-catalog library to  confirm that unpacking
    fails when APIVersion is blank.
    
    Signed-off-by: Noah Sapse <nsapse@redhat.com>
    
    Co-authored-by: Noah Sapse <nsapse@redhat.com>
    Upstream-repository: operator-lifecycle-manager
    Upstream-commit: 3002cf79ce867e32d30d2190df642eaa7f449294
    2 people authored and perdasilva committed May 13, 2022
    Copy the full SHA
    a811ba2 View commit details
    Browse the repository at this point in the history