Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2088541: Update catalog source pod security context #309

Merged
merged 2 commits into from Jun 21, 2022
Merged

Bug 2088541: Update catalog source pod security context #309

merged 2 commits into from Jun 21, 2022

Conversation

perdasilva
Copy link
Contributor

@perdasilva perdasilva commented May 24, 2022 •
edited

Updates the pod and unpack job security context to be more restrictive

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 24, 2022
@openshift-ci openshift-ci bot requested review from benluddy and hasbro17 May 24, 2022 08:18
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2022
@perdasilva perdasilva force-pushed the catalog_sec branch 3 times, most recently from 975e85e to dc160ba Compare June 13, 2022 18:17
@perdasilva perdasilva changed the title [WIP] Catalog sec Bug 2088541: Update pod and unpack job security context Jun 13, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jun 13, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 13, 2022

@perdasilva: This pull request references Bugzilla bug 2088541, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

In response to this:

Bug 2088541: Update pod and unpack job security context

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from jianzhangbjz June 13, 2022 18:19
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 13, 2022

@perdasilva: This pull request references Bugzilla bug 2088541, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

In response to this:

Bug 2088541: Update pod and unpack job security context

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@perdasilva perdasilva force-pushed the catalog_sec branch 8 times, most recently from 06eaf9b to 52599d0 Compare June 21, 2022 08:16
@perdasilva
Copy link
Contributor Author

/test e2e-gcp-olm-flaky

@perdasilva
Copy link
Contributor Author

/test e2e-gcp-console-olm

@perdasilva
Copy link
Contributor Author

/retest e2e-gcp-olm-flaky

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 21, 2022

@perdasilva: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test e2e-gcp
  • /test e2e-gcp-console-olm
  • /test e2e-gcp-olm
  • /test e2e-upgrade
  • /test images
  • /test unit-api
  • /test unit-olm
  • /test unit-psm
  • /test unit-registry
  • /test verify

The following commands are available to trigger optional jobs:

  • /test e2e-gcp-olm-flaky

Use /test all to run all jobs.

In response to this:

/retest e2e-gcp-olm-flaky

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@perdasilva
Copy link
Contributor Author

/test e2e-gcp

@perdasilva
Copy link
Contributor Author

/test e2e-gcp-olm-flaky

@perdasilva
Copy link
Contributor Author

/retest

@perdasilva
Copy link
Contributor Author

/retest-required

@perdasilva perdasilva changed the title Bug 2088541: Update pod and unpack job security context Bug 2088541: Update catalog source pod security context Jun 21, 2022
@perdasilva
Update CatalogSource Pod security context (#2782)
89ed108 
* Update ci artifact collection

Signed-off-by: perdasilva <perdasilva@redhat.com>

* Update e2e test images to use FBC

Signed-off-by: perdasilva <perdasilva@redhat.com>

* Update CatalogSource Pod security context

Signed-off-by: perdasilva <perdasilva@redhat.com>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 99b51e733a3659d14a298731f89f1e36405608f5
@perdasilva
Bump base images to go1.18
f2c0cd2 
Signed-off-by: perdasilva <perdasilva@redhat.com>
@perdasilva
Copy link
Contributor Author

/retest-required

1 similar comment
@perdasilva
Copy link
Contributor Author

/retest-required

dinhxuanvu
dinhxuanvu reviewed Jun 21, 2022
View reviewed changes
Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2022
@dinhxuanvu
Copy link
Member

/test e2e-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 21, 2022

@perdasilva: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 8ee785c into openshift:master Jun 21, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 21, 2022

@perdasilva: All pull requests linked via external trackers have merged:

Bugzilla bug 2088541 has been moved to the MODIFIED state.

In response to this:

Bug 2088541: Update catalog source pod security context

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Jun 22, 2022
@openshift-ci @perdasilva
Merge pull request openshift#309 from perdasilva/catalog_sec
2fca5ee 
Bug 2088541: Update catalog source pod security context

Signed-off-by: perdasilva <perdasilva@redhat.com>
This was referenced Jun 22, 2022
Merged
Merged
@jianzhangbjz
Copy link
Contributor

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jun 27, 2022
tmshort added a commit to tmshort/operator-framework-olm that referenced this pull request Nov 28, 2023
@tmshort
[chore]: Update opentelemetry to v1.20.0 (openshift#309)
2df4b00 
Signed-off-by: Todd Short <todd.short@me.com>
Upstream-repository: api
Upstream-commit: ff0fe0e5ef296845955f251c5bf61f04d5940b4f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinhxuanvu dinhxuanvu dinhxuanvu left review comments

@benluddy benluddy Awaiting requested review from benluddy

@hasbro17 hasbro17 Awaiting requested review from hasbro17

@jianzhangbjz jianzhangbjz Awaiting requested review from jianzhangbjz

Assignees

@dinhxuanvu dinhxuanvu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@perdasilva @dinhxuanvu @jianzhangbjz