Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2088541: Add psa anotations to namespace to suppress warnings #478

Merged
merged 1 commit into from Jun 23, 2022

Conversation

perdasilva
Copy link
Contributor

Signed-off-by: perdasilva perdasilva@redhat.com

Description of the change:
Adds psa annotations for the openshift-marketplace namespace to suppress PSA warnings in 4.11

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2022
@perdasilva perdasilva changed the title Add psa anotations to namespace to suppress warnings Bug 2088541: Add psa anotations to namespace to suppress warnings Jun 23, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 23, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2022

@perdasilva: This pull request references Bugzilla bug 2088541, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

In response to this:

Bug 2088541: Add psa anotations to namespace to suppress warnings

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2022

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: jianzhangbjz.

Note that only operator-framework members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@perdasilva: This pull request references Bugzilla bug 2088541, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

In response to this:

Bug 2088541: Add psa anotations to namespace to suppress warnings

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bparees
Copy link

bparees commented Jun 23, 2022

lgtm

@joelanford
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2022
Signed-off-by: perdasilva <perdasilva@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2022
@joelanford
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2022
@perdasilva
Copy link
Contributor Author

/test e2e-gcp-console-olm

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@perdasilva
Copy link
Contributor Author

/test e2e-gcp-serial

@timflannagan
Copy link
Contributor

Interesting...

Jun 23 16:35:52.000 W ns/openshift-marketplace pod/certified-operators-dchw9 node/ci-op-stnpvw2q-c2bac-2zf6f-master-2 reason/Unhealthy Startup probe failed: command timed out

@perdasilva
Copy link
Contributor Author

Interesting...

Jun 23 16:35:52.000 W ns/openshift-marketplace pod/certified-operators-dchw9 node/ci-op-stnpvw2q-c2bac-2zf6f-master-2 reason/Unhealthy Startup probe failed: command timed out

That is weird @dinhxuanvu any ideas what could be the issue? Maybe networking wasn't setup properly on the cluster deployment?

@dinhxuanvu
Copy link
Member

dinhxuanvu commented Jun 23, 2022

Interesting...

Jun 23 16:35:52.000 W ns/openshift-marketplace pod/certified-operators-dchw9 node/ci-op-stnpvw2q-c2bac-2zf6f-master-2 reason/Unhealthy Startup probe failed: command timed out

That is weird @dinhxuanvu any ideas what could be the issue? Maybe networking wasn't setup properly on the cluster deployment?

I'm not sure why. The startupProbe is using the same health check command that liveness and readiness use and we have pretty generous time duration for startupProbe as well (2.5 minutes). Maybe just a flake. Will see if it pops up again.

@timflannagan
Copy link
Contributor

Looking at that (still running) e2e-gpc-serial test, it appears the test was successful so maybe we're in the clear here? We're still waiting for the test logs to get populated, which is where I found that warning log message initially.

@openshift-ci openshift-ci bot merged commit 040c64e into operator-framework:master Jun 23, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2022

@perdasilva: All pull requests linked via external trackers have merged:

Bugzilla bug 2088541 has been moved to the MODIFIED state.

In response to this:

Bug 2088541: Add psa anotations to namespace to suppress warnings

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jianzhangbjz
Copy link
Contributor

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jun 27, 2022
@perdasilva
Copy link
Contributor Author

/cherry-pick release-4.11

@openshift-cherrypick-robot

@perdasilva: new pull request could not be created: failed to create pull request against operator-framework/operator-marketplace#release-4.11 from head openshift-cherrypick-robot:cherry-pick-478-to-release-4.11: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between operator-framework:release-4.11 and openshift-cherrypick-robot:cherry-pick-478-to-release-4.11"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

In response to this:

/cherry-pick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants