OCPBUGS-122: Psa legacy catalog enablement #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hift#259) Upstream-commit: c6d2f45bf2e87da37ba1abd19a969faa7975e582 Upstream-repository: api
…extConfig (openshift#261) Accepted values for SecurityContextConfig(string): legacy/resctricted(default) Upstream-commit: dfe859e2cf10757aa4cd0eef99917637c8feace9 Upstream-repository: api
openshift-ci
bot
added
the
approved
|
/test unit-olm |
|
Not sure why the unit test is failing here, I'll come and take a look at it tomorrow. I just ran it locally and it passed: Also, the PR hasn't added any unit tests yet. |
|
I guess this PR title should contain the bug id: |
Test passed, details in https://issues.redhat.com/browse/OCPBUGS-122. I will add the |
anik120
changed the title
openshift-ci-robot
added
the
jira/severity-important
|
@anik120: This pull request references Jira Issue OCPBUGS-122, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
jira/invalid-bug
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@anik120: This pull request references Jira Issue OCPBUGS-122, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test unit-olm |
|
/retest unit |
|
@awgreene: The
The following commands are available to trigger optional jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test unit-olm |
…(#2845) * (chore) vendor in o-f/api v0.17.1 Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com> * (psa) allow legacy Catalogsources to run in non-restrcted namespaces This PR configures the Catalogsource reconciler to use the spec.GrpcPodConfig.SecurityContextConfig field to determine if the pod.spec.securityContext and container[*].spec.SecurityContext for the registry pod should be configured to be runnable in a PSA restrcited namespace or not, so that cluster admins can indicate that they want to run legacy catalogsources in a non-resctricted (baseline/privileged) namespace. This allows cluster admins to run catalogsources that are built with a version of opm that is less than v1.23.2 (i.e a version of opm that does not contain [this commit](operator-framework/operator-registry#974) Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com> Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com> Upstream-commit: edffd9c83c3065073e5f91ff0d7c7b78a5c77063 Upstream-repository: operator-lifecycle-manager
This PR adds unit tests to test the pod+container securityContext configs introduced in #2854 Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com> Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com> Upstream-commit: 71f128a14e02e02a19c3f4c2e2b937d3693800f7 Upstream-repository: operator-lifecycle-manager
anik120
force-pushed
the
psa-legacy-catalog-enablement
branch
from
eb665f6
to
2e97ba5
Compare
|
/test e2e-gcp-console-olm |
@jianzhangbjz the issue's been taken care of (my commit had unwanted staging/operator-lifecycle-manager/vendor/ files) /hold for QE label |
openshift-ci
bot
added
the
do-not-merge/hold
timflannagan
approved these changes
Sep 15, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anik120, timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/uncc |
|
@anik120: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
LGTM, details: https://issues.redhat.com/browse/OCPBUGS-122 |
openshift-ci
bot
added
qe-approved
|
@anik120: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-122 has been moved to the MODIFIED state. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
perdasilva
added a commit
to perdasilva/operator-framework-olm
that referenced
this pull request
Nov 30, 2022
perdasilva
added a commit
to perdasilva/operator-framework-olm
that referenced
this pull request
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.