Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug 1560778. Reduce the number of index-patterns for cluster admins #1048

Merged

Conversation

jcantrill
Copy link
Contributor

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 3, 2018
@jcantrill
Copy link
Contributor Author

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 3, 2018
@jcantrill
Copy link
Contributor Author

/test logging
/test json-file

@richm
Copy link
Contributor

richm commented Apr 3, 2018

/test logging

@richm
Copy link
Contributor

richm commented Apr 3, 2018

/test json-file

@jcantrill
Copy link
Contributor Author

/test logging
/test json-file

@jcantrill
Copy link
Contributor Author

@richm I see both these tests fail on tests related to rsyslog which is unrelated to the change introduced by this PR. I'm inclined to manually merge. Thoughts?

@jcantrill jcantrill force-pushed the 1563230_limit_index_patterns branch from db45f02 to 43000a1 Compare April 4, 2018 12:26
@jcantrill
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 4, 2018
@jcantrill jcantrill added the backport/3.9 backport this PR to release-3.9 label Apr 4, 2018
@richm
Copy link
Contributor

richm commented Apr 4, 2018

@richm I see both these tests fail on tests related to rsyslog which is unrelated to the change introduced by this PR. I'm inclined to manually merge. Thoughts?

CI is failing all over the place, not just at rsyslog, and appears to be unrelated to the PRs which are being tested. So sure, we can force merge many of the PRs.

@jcantrill
Copy link
Contributor Author

/test logging
/test json-file

1 similar comment
@jcantrill
Copy link
Contributor Author

/test logging
/test json-file

@richm
Copy link
Contributor

richm commented Apr 6, 2018

access control failure
/test json-file

@jcantrill
Copy link
Contributor Author

/test json-file

1 similar comment
@jcantrill
Copy link
Contributor Author

/test json-file

@richm
Copy link
Contributor

richm commented Apr 17, 2018

/retest

1 similar comment
@richm
Copy link
Contributor

richm commented Apr 18, 2018

/retest

@richm
Copy link
Contributor

richm commented Apr 24, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2018
@ewolinetz
Copy link
Contributor

/lgtm

Copy link
Contributor

@portante portante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@nhosoi
Copy link
Contributor

nhosoi commented Apr 27, 2018

/retest

@richm
Copy link
Contributor

richm commented Apr 28, 2018

/test json-file

1 similar comment
@nhosoi
Copy link
Contributor

nhosoi commented Apr 29, 2018

/test json-file

@openshift-merge-robot openshift-merge-robot merged commit c3aec8a into openshift:master Apr 29, 2018
@richm
Copy link
Contributor

richm commented Apr 30, 2018

/cherrypick 3.9
@jcantrill is there a different patch for es5.x?

@openshift-cherrypick-robot

@richm: cannot checkout 3.9: error checking out 3.9: exit status 1. output: error: pathspec '3.9' did not match any file(s) known to git.

In response to this:

/cherrypick 3.9
@jcantrill is there a different patch for es5.x?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@richm
Copy link
Contributor

richm commented Apr 30, 2018

/cherrypick release-3.9

@openshift-cherrypick-robot

@richm: new pull request could not be created: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:release-3.9 and openshift-cherrypick-robot:cherry-pick-1048-to-release-3.9"}],"documentation_url":"https://developer.github.com/v3/pulls/#create-a-pull-request"}

In response to this:

/cherrypick release-3.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcantrill
Copy link
Contributor Author

@richm There will have to be if I already didnt merge it into 5.x. Was tracking them here: fabric8io/openshift-elasticsearch-plugin#124

@jcantrill jcantrill deleted the 1563230_limit_index_patterns branch April 30, 2018 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/completed backport/es5.x backport/3.9 backport this PR to release-3.9 lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants