Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1560778 on 39 #1068

Merged
merged 1 commit into from
Apr 13, 2018
Merged

1560778 on 39 #1068

merged 1 commit into from
Apr 13, 2018

Conversation

jcantrill
Copy link
Contributor

3.9 cherrypick of #1048

@jcantrill jcantrill requested a review from ewolinetz April 5, 2018 17:00
@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 5, 2018
@jcantrill jcantrill changed the base branch from master to release-3.9 April 5, 2018 17:01
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 5, 2018
@jcantrill jcantrill added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. backport/3.9 backport this PR to release-3.9 and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 5, 2018
ewolinetz
ewolinetz approved these changes Apr 5, 2018
View reviewed changes
Copy link
Contributor

@ewolinetz ewolinetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2018
@richm
Copy link
Contributor

richm commented Apr 6, 2018

access control failure
/test json-file

@jcantrill
Copy link
Contributor Author

/refresh

@jcantrill jcantrill removed the backport/3.9 backport this PR to release-3.9 label Apr 6, 2018
@jcantrill
Copy link
Contributor Author

/test json-file
/test logging

@jcantrill
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 0328b12 into openshift:release-3.9 Apr 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewolinetz ewolinetz ewolinetz approved these changes

Assignees

@ewolinetz ewolinetz

Labels
lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jcantrill @richm @ewolinetz @openshift-ci-robot @openshift-merge-robot