Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1748478: Add more states to init probe #1786

Merged
merged 1 commit into from Nov 14, 2019
Merged

Bug 1748478: Add more states to init probe #1786

merged 1 commit into from Nov 14, 2019

Conversation

jcantrill
Copy link
Contributor

@openshift-ci-robot
Copy link

@jcantrill: This pull request references Bugzilla bug 1748478, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1748478: Add more states to init probe

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 8, 2019
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 8, 2019
@jcantrill jcantrill added kind/bug Categorizes issue or PR as related to a bug. release/4.3 and removed bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 8, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2019
@ewolinetz
Copy link
Contributor

/lgtm

richm
richm approved these changes Nov 11, 2019
View reviewed changes
Copy link
Contributor

@richm richm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ewolinetz, jcantrill, richm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ewolinetz,jcantrill,richm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jcantrill
Copy link
Contributor Author

/retest

@jcantrill
Copy link
Contributor Author

/test upgrade-full-integ-aws

@richm
Copy link
Contributor

richm commented Nov 12, 2019

not sure if this is a flake - the errors are in es/sg related code - access control and multi-tenancy - maybe something to do with es startup/readiness?

@richm
Copy link
Contributor

richm commented Nov 12, 2019

not sure if this is a flake - the errors are in es/sg related code - access control and multi-tenancy - maybe something to do with es startup/readiness?

yep - not a flake - it is failing consistently in the same places

@jcantrill
Copy link
Contributor Author

/test upgrade-full-integ-aw

@jcantrill
Copy link
Contributor Author

not sure if this is a flake - the errors are in es/sg related code - access control and multi-tenancy - maybe something to do with es startup/readiness?

yep - not a flake - it is failing consistently in the same places

ran the multi-tenant test locally with success. the access control test failed on a line where I was missing an artifact dir towards the end; hoping this is local env issu

@richm
Copy link
Contributor

richm commented Nov 13, 2019

/retest

@richm
Copy link
Contributor

richm commented Nov 14, 2019

aws flake
/retest

@openshift-merge-robot openshift-merge-robot merged commit c1dfa00 into openshift:master Nov 14, 2019
@openshift-ci-robot
Copy link

@jcantrill: All pull requests linked via external trackers have merged. Bugzilla bug 1748478 has been moved to the MODIFIED state.

In response to this:

Bug 1748478: Add more states to init probe

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcantrill jcantrill deleted the 1748478_deux branch November 14, 2019 03:09
@jcantrill
Copy link
Contributor Author

/cherrypick release-3.11

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 28, 2020
Merged
@openshift-cherrypick-robot
Copy link

@jcantrill: new pull request created: #1822

In response to this:

/cherrypick release-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richm richm richm approved these changes

@bparees bparees Awaiting requested review from bparees

@ewolinetz ewolinetz Awaiting requested review from ewolinetz

Assignees

@richm richm

@ewolinetz ewolinetz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release/4.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jcantrill @openshift-ci-robot @ewolinetz @richm @openshift-cherrypick-robot @openshift-merge-robot