Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LOG-1297: Removing JKS files #2100

Merged
merged 1 commit into from
May 21, 2021
Merged

LOG-1297: Removing JKS files #2100

merged 1 commit into from
May 21, 2021

Conversation

Red-GV
Copy link
Contributor

@Red-GV Red-GV commented Apr 12, 2021 •
edited
Loading

Completing the loop for #2077. Requires openshift/elasticsearch-operator#669.

This PR removes the JKS files that were replaced in the previously mentioned PR.

/cc @blockloop
/assign @ewolinetz

Links

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Red-GV
To complete the pull request process, please assign alanconway after the PR has been reviewed.
You can assign the PR to them by writing /assign @alanconway in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Red-GV
Copy link
Contributor Author

Red-GV commented Apr 13, 2021

/retest

1 similar comment
@Red-GV
Copy link
Contributor Author

Red-GV commented Apr 13, 2021

/retest

@ewolinetz
Copy link
Contributor

@Red-GV as soon as we branch for 5.1 we can remove the hold on this
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 4, 2021
@ewolinetz
Copy link
Contributor

/lgtm

@ewolinetz
Copy link
Contributor

/refresh

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2021
@ewolinetz
Copy link
Contributor

/test

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 19, 2021

@ewolinetz: The /test command needs one or more targets.
The following commands are available to trigger jobs:

  • /test clo-functional
  • /test cluster-logging-operator-e2e
  • /test elastic-operator-e2e
  • /test images
  • /test lint
  • /test smoke
  • /test unit

Use /test all to run all jobs.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ewolinetz
Copy link
Contributor

/test all

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm Indicates that a PR is ready to be merged. labels May 19, 2021
@ewolinetz
Copy link
Contributor

/retest

2 similar comments
@ewolinetz
Copy link
Contributor

/retest

@jcantrill
Copy link
Contributor

/retest

@jcantrill jcantrill changed the title Removing JKS files LOG-1297: Removing JKS files May 20, 2021
jcantrill
jcantrill reviewed May 20, 2021
View reviewed changes
Copy link
Contributor

@jcantrill jcantrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ewolinetz
Copy link
Contributor

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 21, 2021
@ewolinetz
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ewolinetz, jcantrill, Red-GV

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ewolinetz,jcantrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit a71c71b into openshift:master May 21, 2021
@Red-GV Red-GV deleted the remove-jks-files branch June 28, 2021 12:18
@periklis periklis mentioned this pull request Sep 2, 2021
Closed
@periklis periklis mentioned this pull request Sep 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcantrill jcantrill jcantrill left review comments

@blockloop blockloop Awaiting requested review from blockloop

Assignees

@ewolinetz ewolinetz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Red-GV @openshift-ci-robot @ewolinetz @jcantrill @openshift-merge-robot