Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #729. remove ref to deployer #759

Merged
merged 1 commit into from
Nov 11, 2017
Merged

fixes #729. remove ref to deployer #759

merged 1 commit into from
Nov 11, 2017

Conversation

jcantrill
Copy link
Contributor

fixes #729 by removing ref to the deployer

@openshift-ci-robot openshift-ci-robot added retest-not-required-docs-only size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 2, 2017
richm
richm reviewed Nov 2, 2017
View reviewed changes
HACKING.md Outdated
In order to run a deployment with these images, you would process the
[deployer template](deployer/deployer.yaml) with the `IMAGE_PREFIX`
parameter pointing to the cluster registry location (e.g `IMAGE_PREFIX=172.30.90.128:5000/logs/`).
In order to run deploy logging with these images, you set the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove run

richm
richm reviewed Nov 2, 2017
View reviewed changes
HACKING.md Outdated
parameter pointing to the cluster registry location (e.g `IMAGE_PREFIX=172.30.90.128:5000/logs/`).
In order to run deploy logging with these images, you set the
[openshift-installer](https://github.com/openshift/openshift-ansible/tree/master/roles/openshift_logging)
inventory varible `openshift_logging_install_logging` to the cluster registry location (e.g `172.30.90.128:5000/logs/`).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

variable

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is right - openshift_logging_install_logging is a boolean?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct, its a boolean

@0xmichalis
Copy link
Contributor

/cherrypick release-3.6

@openshift-cherrypick-robot
Copy link

@Kargakis: @Kargakis once the present PR merges, I will cherry-pick it on top of release-3.6 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

richm
richm reviewed Nov 6, 2017
View reviewed changes
HACKING.md Outdated
parameter pointing to the cluster registry location (e.g `IMAGE_PREFIX=172.30.90.128:5000/logs/`).
In order to deploy logging with these images, you set the
[openshift-installer](https://github.com/openshift/openshift-ansible/tree/master/roles/openshift_logging)
inventory variable `openshift_logging_install_logging` to the cluster registry location (e.g `172.30.90.128:5000/logs/`).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct? I thought openshift_logging_install_logging was a boolean?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct, its a boolean

@richm
Copy link
Contributor

richm commented Nov 10, 2017

/retest

@richm richm added lgtm Indicates that a PR is ready to be merged. kind/bug Categorizes issue or PR as related to a bug. labels Nov 11, 2017
@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 6f7c2b4 into openshift:master Nov 11, 2017
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 11, 2017
Merged
@openshift-cherrypick-robot
Copy link

@Kargakis: New pull request created: #782

In response to this:

/cherrypick release-3.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot added a commit that referenced this pull request Nov 13, 2017
@openshift-merge-robot
Merge pull request #782 from openshift-cherrypick-robot/cherry-pick-7…
5f14edc 
…59-to-release-3.6

Automatic merge from submit-queue.

Automated cherry-pick of #759 on release-3.6

This is an automated cherry-pick of #759

/assign kargakis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richm richm richm left review comments

@ewolinetz ewolinetz Awaiting requested review from ewolinetz

Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. retest-not-required-docs-only size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bad link in HACKING.md
7 participants
@jcantrill @0xmichalis @openshift-cherrypick-robot @richm @openshift-merge-robot @ewolinetz @openshift-ci-robot