Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #729. remove ref to deployer #759

Merged
merged 1 commit into from
Nov 11, 2017
Merged

fixes #729. remove ref to deployer #759

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 3 additions & 19 deletions HACKING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@ This will start the builds in the background. Use oc logs -f build/<component> t
follow the build logs, or use oc start-build --follow <component> to run the build
in the foreground and follow the build logs.

In order to run a deployment with these images, you would process the
[deployer template](deployer/deployer.yaml) with the `IMAGE_PREFIX`
parameter pointing to the cluster registry location (e.g `IMAGE_PREFIX=172.30.90.128:5000/logs/`).
In order to deploy logging with these images, you set the
[openshift-installer](https://github.com/openshift/openshift-ansible/tree/master/roles/openshift_logging)
inventory variable `openshift_logging_image_prefix` to the cluster registry location (e.g `172.30.90.128:5000/logs/`).

## Building locally

Expand All @@ -47,19 +47,3 @@ directory of this repo:
```
$PREFIX=docker.io/mynamespace/myloggingprefix- $OS_TAG=v1.x make
```

## Running the deployer script locally

When developing the deployer, it is fairly tedious to rebuild the image
and redeploy it just for tiny iterative changes. The deployer script
is designed to be run either in the deployer image or directly. It
requires the openshift and oc binaries as well as the Java 8 JDK. When
run directly, it will use your current client context to create all
the objects, but you must still specify at least the PROJECT env var in
order to create everything with the right parameters. E.g.:

cd deployer
PROJECT=logging ./run.sh

There are a number of env vars this script looks at which are useful
when running directly; check the script headers for details.