This repository has been archived by the owner on Aug 29, 2018. It is now read-only.
Bug 992464 - Authorization token needs to raise when checking eventual consistency #3290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l consistency Was using .first which returns nil
| @@ -44,7 +44,7 @@ class Authorization | |||
| scope :not_expired, lambda{ where(:expires_at.gt => DateTime.now, :revoked_at => nil) } | |||
|
|
|||
| def self.authenticate(token) | |||
| with(consistency: :eventual).where(token: token).first | |||
| with(consistency: :eventual).where(token: token).find_by | |||
There was a problem hiding this comment.
why not use --> with(consistency: :eventual).find_by(token: token)
There was a problem hiding this comment.
Just to be consistent with the rescue block
|
[merge] reviewed. |
|
Online Merge Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/merge_pull_requests/3425/) (Image: devenv_3644) |
|
Evaluated for online up to 340e910 |
|
[Test]ing while waiting on the merge queue |
|
Origin Test Results: SUCCESS (https://originci-openshift.rhcloud.com/job/test_pull_requests/1651/) |
|
Evaluated for origin up to 340e910 |
|
Online Test Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/3815/) |
openshift-bot
pushed a commit
that referenced
this pull request
Aug 13, 2013
…n_not_found_token Merged by openshift-bot
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was using .first which returns nil
@abhgupta review please