This repository has been archived by the owner on Aug 29, 2018. It is now read-only.
oo-accept-node: Handle non-existence of /sbin/ip #5624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify check_node_public_resolution to rescue from Errno::ENOENT when running /sbin/ip in case the command does not exist. This change makes check_node_public_resolution consistent with the find_ext_net_dev test. This commit fixes bug 1121224.
|
[test] |
|
Origin Test Results: FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests/2653/) |
|
Online Test Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/7989/) |
|
[test] again because the errors were caused by MongoDB connection failures that are probably unrelated to the change in the pull request. |
|
Evaluated for origin up to d25e6a6 |
|
[merge] |
|
Online Merge Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/merge_pull_requests/5709/) |
|
Evaluated for online up to d25e6a6 |
openshift-bot
pushed a commit
that referenced
this pull request
Jul 22, 2014
…e-non-existence-of-slash-sbin-slash-ip Merged by openshift-bot
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify
check_node_public_resolutionto rescue fromErrno::ENOENTwhen running/sbin/ipin case the command does not exist. This change makescheck_node_public_resolutionconsistent with thefind_ext_net_devtest.This commit fixes bug 1121224.