Skip to content
This repository has been archived by the owner on Aug 29, 2018. It is now read-only.

Delete unused variables in Upgrader #6249

Merged

Conversation

Miciah
Copy link
Contributor

@Miciah Miciah commented Sep 29, 2015

[test]

@Miciah Miciah changed the title Delete unused variabels in Upgrader Delete unused variables in Upgrader Sep 29, 2015
@Miciah Miciah force-pushed the delete-unused-variables-in-upgrader branch from 8f93182 to 5db0286 Compare September 29, 2015 20:57
@openshift-bot
Copy link

Online Test Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/8991/) (Extended Tests: gear)

@Miciah
Copy link
Contributor Author

Miciah commented Oct 1, 2015

Test failure looks unrelated to the changes in the PR:

  Installing : drupal6-openshift-features-forums-1.9.1-1.git.0.30511a5.   83/84 
E, [2015-09-29T19:18:36.163127 #9780] ERROR -- : 
SSH command to ec2-54-85-43-124.compute-1.amazonaws.com timed out (timeout = 7200)

[test] again.

@Miciah
Copy link
Contributor Author

Miciah commented Oct 1, 2015

Weird—it timed out in the same place:

  Installing : drupal6-openshift-features-forums-1.9.1-1.git.0.30511a5.   83/84 
E, [2015-10-01T15:52:17.072713 #20403] ERROR -- : 
SSH command to ec2-52-23-218-102.compute-1.amazonaws.com timed out (timeout = 7200)

[test] again.

@Miciah
Copy link
Contributor Author

Miciah commented Oct 6, 2015

Failed on the following, which was fixed by https://www.github.com/openshift/rhc/pull/703:

Bundler could not find compatible versions for gem "net-ssh":
  In Gemfile:
    rhc (>= 0) ruby depends on
      net-ssh (< 2.9.3, >= 2.0.11) ruby

    rhc (>= 0) ruby depends on
      net-ssh (3.0.1)

[test] again.

@Miciah
Copy link
Contributor Author

Miciah commented Oct 26, 2015

I will tag this PR to have the gear extended tests run on it once #6291 is merged.

@Miciah
Copy link
Contributor Author

Miciah commented Oct 27, 2015

[test] [extended:gear]

@openshift-bot
Copy link

Evaluated for online test up to 5db0286

@Miciah
Copy link
Contributor Author

Miciah commented Jul 27, 2016

@tiwillia, I have this way old cleanup PR. Looks like the last test run succeeded—think it's worth merging?

@tiwillia
Copy link
Member

I'm wary to merge anything we don't explicitly need at this point, but this PR is rather harmless.

Lets [merge] it.

@openshift-bot
Copy link

openshift-bot commented Jul 27, 2016

Online Merge Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/9347/) (Image: devenv_5808)

@openshift-bot
Copy link

Evaluated for online merge up to 5db0286

@openshift-bot openshift-bot merged commit aeb7a2b into openshift:master Jul 27, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants