This repository has been archived by the owner on Aug 29, 2018. It is now read-only.
Use updated fakefs to ensure support for File.absolute_path #6411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[test] just for fun's sake. |
|
Evaluated for online test up to 0475806 |
|
@Miciah, can you review/merge this when you get a chance? |
|
So in discussions on IRC, we thought the version of fakefs was too new, but it turns out it was too old; is that right? |
|
@Miciah that is correct. fakefs was too old and did not support some methods that have been implemented in |
|
Online Test Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/9360/) |
|
Hold off on this please, don't merge yet. |
|
This isn't necessary, a newer version will always be used. Closing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of fakes-0.4.2 causes erroneous test failures due to the lack of
File.absolute_pathsupport. Updating to 0.5.* allows tests to succeed without causing further issues.In origin-server tests, fakefs-0.9 is used by default. This change will have no affect on origin-server tests, but will ensure that tests run in other deployments will be run properly.
@thrasher-redhat fyi