This repository has been archived by the owner on Aug 29, 2018. It is now read-only.
routing-daemon: F5: Try harder to delete client-ssl profile #6442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
F5IControlRestLoadBalancerModel#remove_ssl: Try to delete the client-ssl profile even if deleting it from the virtual server fails; try to delete the key even if deleting the client-ssl fails; and try to delete the certificate even if deleting the key fails. LBModelExceptionCollector: New helper class to rescue, collect, and combine LBModelException exceptions. F5 BIG-IP will not let us delete a resource that is in use (e.g., a client-ssl profile that is still associated with a virtual server), but this change will enable the routing-daemon to finish cleaning up a client-ssl profile or associated key or certificate that is already deleted from the virtual server.
|
LGTM. Always good to try harder. |
|
Thanks! openshift-bot, please [merge]! |
|
Evaluated for online merge up to c2c403f |
|
Online Merge Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/9454/) (Base Commit: 694c7e8) (Image: devenv_5837) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
F5IControlRestLoadBalancerModel#remove_ssl: Try to delete the client-ssl profile even if deleting it from the virtual server fails; try to delete the key even if deleting the client-ssl fails; and try to delete the certificate even if deleting the key fails.LBModelExceptionCollectorNew helper class to rescue, collect, and combineLBModelExceptionexceptions.F5 BIG-IP will not let us delete a resource that is in use (e.g., a client-ssl profile that is still associated with a virtual server), but this change will enable the routing-daemon to finish cleaning up a client-ssl profile or associated key or certificate that is already deleted from the virtual server.
This commit fixes bug 1406251.
https://bugzilla.redhat.com/show_bug.cgi?id=1406251
@thrasher-redhat