Add SVG icons #465
Add SVG icons #465
Conversation
spadgett
force-pushed
the
logos
branch
2 times, most recently
from
da67ed2
to
1e22bcf
Compare
|
@jeff-phillips-18 PTAL |
| @@ -1,7 +1,8 @@ | |||
| <div class="order-service-details"> | |||
| <div class="order-service-details-top"> | |||
| <div class="service-icon"> | |||
| <span class="icon {{$ctrl.imageStream.iconClass}}" aria-hidden="true"></span> | |||
| <span ng-if="!$ctrl.imageStream.imageUrl" class="icon {{$ctrl.imageStreamiconClass}}" aria-hidden="true"></span> | |||
| <span ng-if="$ctrl.imageStream.imageUrl" class="image"><img ng-src="{{$ctrl.imageStream.imageUrl}}" alt=""></span> | |||
There was a problem hiding this comment.
For img elements, I don't think aria-hidden is needed if alt="" is set.
|
Looks good. One question, should there be methods to get the image for a given service instance thus allowing us to show the image in other places in the UI (like the service instance details page)? |
Yeah, I know @ncameronbritt had started looking at showing icons generally on the overview. We could pretty easily add them for service instances since there is a clear icon, at least on the details page. @ncameronbritt Opinion? |
|
@jeff-phillips-18 Opened #2221 to discuss using the icon elsewhere. |
openshift-ci-robot
added
the
size/L
Use color SVG icons instead of font icons when available. Bumps origin-web-common from 0.0.63 -> 0.0.64 for the `imageForIconClass` filter.
Use SVG icons when available.
See openshift/origin-web-console#2208
Requires openshift/origin-web-common#213